Skip to content
This repository has been archived by the owner on Jun 13, 2019. It is now read-only.

currkey not defined #212

Open
abusedmedia opened this issue Jun 30, 2016 · 5 comments
Open

currkey not defined #212

abusedmedia opened this issue Jun 30, 2016 · 5 comments

Comments

@abusedmedia
Copy link
Contributor

Hi @cadecairos

I've seen you've fixed the currkey definition but it doesn't work on mobile yet.

After a bit of investigation it looks like uglify, in you're build system, doesn't handle properly that variable during minification process (basically it strips the definition you put and few lines below a statement try to use that variable without success, throwing the error).
This doesn't happen in my build process though, this is why it came up recently.

Long story short: I cannot fix it since it's a builder (gulp/uglify) issue, maybe it's a node_module version issue... don't know.. hope this help, though.

@cadecairos
Copy link
Contributor

It seems to work for me on firefox for Android - which device/browser is it not working on?

@abusedmedia
Copy link
Contributor Author

iOS, but you can also see the issue using Chrome with mobile simulator, in console you'll see the error.

@Pomax
Copy link
Contributor

Pomax commented Jun 30, 2016

are the specific steps I can take to see this error? I just cloned master and ran it through the build process, but this does not yield any errors in Chrome with mobile emulation turned on set to iPhone 6

@cadecairos
Copy link
Contributor

I think this happened because I build using node 6 - but staging and production (once we switch to codemoji.org ) will build with node ^4.4.7 - and I don't see the error in that case

@abusedmedia
Copy link
Contributor Author

@cadecairos is right, the current codemoji.org version doesn't have the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants