-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using nullish coalescing operator (??) in files read by jsdoc breaks documentation #150
Comments
Treeherder shows an error when I click the link. Can you paste the message here? JSDoc is responsible for doing the parsing. It looks like it supports nullish coalescing. I'll see if I can repro, but it'd help if I could see your error as well. |
I cannot reproduce a JSDoc crash locally using JSDoc 3.6.3 on this simple file /**
* F is awesome.
*/
let f = null;
console.log(f ?? 'itWuzNullish');
Also, running sphinx-js over the Fathom codebase after inserting a nullish coalescing operator on a documented entity works fine. So I'm doubly eager to see your error. |
I'm not even sure the error is related, but a bunch of warnings start after reading the extension reference, and then ends up in a python stack trace (apologies for the wall of text):
|
I'm sorry I can't help in narrowing this down, but I was never able to run
The patch that triggered the jsdoc issue is from bug 1636508, specifically the first version: |
I don't see anything sphinx-js-specific in there, though it does look like Sphinx's own autodoc directive is blowing up. :-( |
Add ts source files to manifest Specify tsconfig.json in cli args to typedoc
Originally filed in bug 1649882.
This is very inconvenient, we now use ?? in ~half of our files, but as soon as we introduce it in one of the js files referenced in doc generation, it explodes on Try with a very unhelpful error message.
Is there something we can do here? What code or library is responsible for parsing js files for generated docs? Is there a newer version, do we need to update or something?
The text was updated successfully, but these errors were encountered: