Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mozilla-centric things (#233) #234

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Remove Mozilla-centric things (#233) #234

merged 4 commits into from
Sep 29, 2023

Conversation

willkg
Copy link
Member

@willkg willkg commented Sep 28, 2023

No description provided.

@willkg willkg requested a review from lonnen September 28, 2023 17:28
@willkg
Copy link
Member Author

willkg commented Sep 28, 2023

@lonnen I think this covers everything we should do before transferring. Can you think of anything else?

@willkg willkg mentioned this pull request Sep 28, 2023
6 tasks
CONTRIBUTORS Outdated
@@ -0,0 +1,36 @@
Bleach was originally written and maintained by Erik Rose and various

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Bleach was originally written and maintained by Erik Rose and various
sphinx-js was originally written and maintained by Erik Rose and various

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

CONTRIBUTORS Outdated
Bleach was originally written and maintained by Erik Rose and various
contributors within and without the Mozilla Corporation and Foundation.

It is currently maintained by XYZ.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is currently maintained by XYZ.
It is currently maintained by Hood Chatham.

Or I can insert this myself later. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@willkg willkg merged commit 620e2d7 into mozilla:master Sep 29, 2023
4 checks passed
Copy link
Contributor

@lonnen lonnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're removing CODE_OF_CONDUCT.md we should also remove it from MANIFEST.in

@lonnen
Copy link
Contributor

lonnen commented Oct 10, 2023

oops, this was already merged. I'm on it

lonnen added a commit that referenced this pull request Oct 10, 2023
lonnen added a commit that referenced this pull request Oct 10, 2023
@hoodmane
Copy link

I'm planning to add the code of conduct from Pyodide so it's probably not important. But also do we need to put the code of conduct into the wheel?

@willkg
Copy link
Member Author

willkg commented Oct 10, 2023

The MANIFEST.in affects building the source tarball. The source tarball should include the source code and important documents from the repository under which the source code was built. I've always included the code of conduct in that.

Generally, I run check-manifest and fix anything it suggests fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants