Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures should show the printing command #112

Open
eyalroz opened this issue Jul 21, 2021 · 0 comments
Open

Test failures should show the printing command #112

eyalroz opened this issue Jul 21, 2021 · 0 comments

Comments

@eyalroz
Copy link

eyalroz commented Jul 21, 2021

At the moment, when a REQUIRE()/CHECK() in the unit test suite fails, we see the expected value - but we don't see what was actually printed, nor the arguments to the printing command (sprintf_, printf_ etc). These should be visible, so we can better understand what the failure was without consulting the test suite source.

eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
…tion called, the arguments used, and the resulting buffer contents. It's not ideal in terms of layout and reseness, but it does the job.

Also, spacing tweaks for improved readability via alignment of arguments.
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
…tion called, the arguments used, and the resulting buffer contents. It's not ideal in terms of layout and reseness, but it does the job.

Also, spacing tweaks for improved readability via alignment of arguments.
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
…tion called, the arguments used, and the resulting buffer contents. It's not ideal in terms of layout and reseness, but it does the job.

Also, spacing tweaks for improved readability via alignment of arguments.
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
…tion called, the arguments used, and the resulting buffer contents. It's not ideal in terms of layout and reseness, but it does the job.

Also, spacing tweaks for improved readability via alignment of arguments.
eyalroz added a commit to eyalroz/printf that referenced this issue Jul 30, 2021
…tion called, the arguments used, and the resulting buffer contents. It's not ideal in terms of layout and reseness, but it does the job.

Also, spacing tweaks for improved readability via alignment of arguments.
eyalroz added a commit to eyalroz/printf that referenced this issue Aug 3, 2021
…tion called, the arguments used, and the resulting buffer contents. It's not ideal in terms of layout and reseness, but it does the job.

Also, spacing tweaks for improved readability via alignment of arguments.
KarlK90 pushed a commit to qmk/printf that referenced this issue Jul 7, 2022
…g.h` before `printf.c`; and separated cases of what's expected to be printed based on the value of `PRINTF_MAX_INTEGRAL_DIGITS_FOR_DECIMAL`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant