-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid Spacing Support more than 40px #13967
Comments
@oliviertassinari I'm not sure how to handle this, whilst also thinking of your proposed change in #13663
|
@softmarshmallow This is already planned in #12925. I'm suggesting that we support 8 different grid values following what we do with the system package: https://material-ui.com/system/spacing/#transformation. |
@oliviertassinari Where does this limit on 8 different spacings stem from? I would rather leave this to the user and simply add a recommendation to the docs if there are some resources that suggest spacing limits. |
@eps1lon 8 is an arbitrary number. We have to stop somewhere if we are using a static style sheet. We could do 10 not to confound it with |
Oh now I get it: We're creating the rules statically i.e. at build time. Can't we leverage our new styling solution with dynamic styles? |
@eps1lon We can try, otherwise, we can create a Grid generator. |
Need support for Spacing more than 40px.
As referred in doc.
Expected Behavior 🤔
8 px Rule is fine, but there are bunch alot of designs using more spacing than 40px.
64, 128 etc...
Current Behavior 😯
if not followed 8px rule, or over that. the spacing will be ignored and just be 0
The text was updated successfully, but these errors were encountered: