Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Add deDE translations for x-date-pickers #4974

Merged
merged 1 commit into from
May 24, 2022
Merged

[l10n] Add deDE translations for x-date-pickers #4974

merged 1 commit into from
May 24, 2022

Conversation

felixh10r
Copy link
Contributor

Following up on #3211, I'd like to provide German translations for the Date Picker component.

@mui-bot
Copy link

mui-bot commented May 23, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 244.3 511.5 310.4 349.38 106.842
Sort 100k rows ms 436 824.7 701.1 660.7 138.423
Select 100k rows ms 105.8 325.3 184.6 191.48 73.007
Deselect 100k rows ms 98.3 210 171.8 150.7 38.515

Generated by 🚫 dangerJS against 28660fb

@felixh10r felixh10r force-pushed the feat/pickers-de-translations branch from afdd160 to b0867a0 Compare May 23, 2022 09:14
@felixh10r felixh10r force-pushed the feat/pickers-de-translations branch from b0867a0 to 28660fb Compare May 23, 2022 09:36
@m4theushw m4theushw added l10n localization component: pickers This is the name of the generic UI component, not the React module! labels May 23, 2022
@m4theushw m4theushw changed the title [pickers] Add deDE translations for x-date-pickers [l10n] Add deDE translations for x-date-pickers May 23, 2022
flaviendelangle
flaviendelangle approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution !

@flaviendelangle flaviendelangle merged commit 510c10f into mui:master May 24, 2022
@felixh10r felixh10r deleted the feat/pickers-de-translations branch May 24, 2022 11:44
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@felixh10r @alexfauquette
[pickers] Add deDE translations for x-date-pickers (mui#4974)
85241b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixh10r @mui-bot @flaviendelangle @m4theushw