Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment]: Strong Typed Variant in the Params #812

Open
1 task done
philou opened this issue Oct 8, 2024 · 0 comments
Open
1 task done

[Experiment]: Strong Typed Variant in the Params #812

philou opened this issue Oct 8, 2024 · 0 comments
Labels
experiment An experimentation refactoring S Small

Comments

@philou
Copy link
Contributor

philou commented Oct 8, 2024

Contact Details

[email protected]

Feature Request

The variant in the params is currently a string, which spreads error-handling code down to the engine.

Feature Description

Try to use the typed Variant from the Params. We might need to isolate move around code to avoid cyclic dependencies. Yet it would allow us to follow the "Parse don't validate" idiom, and get rid of error-handling code by design.

Then learn and decide what to do.

We might also use the opportunity to push code to the Variant structure when that makes sense

Alternatives

  • keep it as it is

Additional Context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experiment An experimentation refactoring S Small
Development

No branches or pull requests

1 participant