You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After upgrade to Go 1.24 is complete, the following changes could be looked into (cf. Tools / Go command section in Go 1.24 release notes):
Go modules can now track executable dependencies using tool directives in go.mod. TCR is currently using the workaround described in the release note to deal with tool dependencies. We could replace it with the tool dependencies option now that Go tools supports it natively.
The go build command now sets the main module’s version in the compiled binary based on the version control system tag and/or commit. We could leverage on it to manage TCR versionning info, which is currrently done through go build ldflags in Makefile and goreleaser
Code of Conduct
I agree to follow this project's Code of Conduct
To Do List
Upgrade go version to 1.24
Change go version to 1.24 in go modules
src/go.mod (tcr module)
tcr-doc/go.mod (tcr doc generation)
Change go version in GitHub actions
.github/workflows/go.yml
.github/workflows/golangci_lint.yml
.github/workflows/goreleaser.yml
Verify that the 3 steps pass on GitHub
Check build
Check lint
Check release (can only be done after changes are merged on main branch)
Update the development documentation
dev-doc/build.md
Update .golangci.yml
Update examples with go language
examples/go-bazel/go.mod
examples/go-go-tools/go.mod
examples/go-gotestsum/go.mod
examples/go-make/go.mod
Test that there is no regression
Verify that build works
Verify that tests work
Verify that linter doesn't raise any problems
Test that new version works with all existing toolchain (cf. script tools/tcr/verify-tcr-examples.sh)
The text was updated successfully, but these errors were encountered:
Contact Details
[email protected]
Change Request
TCR is currently built with Go 1.23, while version 1.24 is now available.
Change Description
Upgrade go version in tcr module from 1.23 to 1.24.
We should check in particular that:
Alternatives
Stay with Go 1.23
Additional Context
Go 1.24 release notes: https://go.dev/doc/go1.24
After upgrade to Go 1.24 is complete, the following changes could be looked into (cf. Tools / Go command section in Go 1.24 release notes):
Code of Conduct
To Do List
The text was updated successfully, but these errors were encountered: