#24626 misc palette search issues

[krasko78]

Resolves: #24626
Resolves: #15449

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[zacjansheski]

I can produce a crash now (perhaps this should be fixed later on)

1. In text palette, select more
2. Command + F9, search for "ba"
3. esc
4. select more again
5. Command + F9, clear search and search for "ba" again

video1675711105.mp4

[zacjansheski]

PaletteSearchCrash.zip

[krasko78]

Crash confirmed. Thanks @zacjansheski! I'll look into it.

[krasko78]

I think I fixed it.

[zacjansheski]

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved
#24626 FIXED
#15449 FIXED

[krasko78]

@cbjeukendrup If I make changes after the PR has been approved (like in this case a crash was discovered during the testing), how are you guys supposed to review them? Should I notify you, re-request a review or something?

[cbjeukendrup]

We're usually already notified by GitHub's email notifications like "@\krasko pushed 1 new commit", so we take one more look before merging it.
@RomanPudashkin Would you mind taking care of doing that for this PR?