Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no way to move an imported picture after one try #24791

Closed
4 tasks done
MatthieuS-ctrl opened this issue Sep 18, 2024 · 12 comments · Fixed by #25030
Closed
4 tasks done

no way to move an imported picture after one try #24791

MatthieuS-ctrl opened this issue Sep 18, 2024 · 12 comments · Fixed by #25030
Assignees
Labels
P1 Priority: High regression MS4 Regression on a prior release UX/interaction

Comments

@MatthieuS-ctrl
Copy link

MatthieuS-ctrl commented Sep 18, 2024

Issue type

UX/Interaction bug (incorrect behaviour)

Description with steps to reproduce

I tried with .jpg and .png with small files of around 150KB, which I have always used to illustrate scores for children.

The image can be moved for the first time, and you can continue to move it as long as it is not deselected.

Once deselected, the number of test shots becomes random: either it is impossible to move it again (the image is then integrated into the score, and it is the whole that moves), or you are entitled to do so. to a second manipulation possibility, but I was able to go up to 4.

In short, I haven't been able to precisely identify the problem....

Supporting files, videos and screenshots

459440959_3859847137578202_8334505033483737385_n

What is the latest version of MuseScore Studio where this issue is present?

4.4.2

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Windows 10

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible
@muse-bot muse-bot added regression MS3 Regression from MS3 (3.6.2) UX/interaction labels Sep 18, 2024
@MatthieuS-ctrl MatthieuS-ctrl changed the title now way to move an imported picture after one try no way to move an imported picture after one try Sep 18, 2024
@oktophonie
Copy link
Contributor

Can you let us know which version of MuseScore you are using? I cannot reproduce this in 4.4.2 in Linux or Windows.

@MatthieuS-ctrl
Copy link
Author

Hello, it happened on version 4.4.1, so I update with 4.4.2 yesterday, and there is still this problem

@oktophonie oktophonie added the needs review The issue needs review to set priority, fix version or change status etc. label Sep 18, 2024
@MatthieuS-ctrl
Copy link
Author

I tried with .jpg and .png with small files of around 150KB, which I have always used to illustrate scores for children.

The image can be moved for the first time, and you can continue to move it as long as it is not deselected.

Once deselected, the number of test shots becomes random: either it is impossible to move it again (the image is then integrated into the score, and it is the whole that moves), or you are entitled to do so. to a second manipulation possibility, but I was able to go up to 4.

In short, I haven't been able to precisely identify the problem....

@MarcSabatella
Copy link
Contributor

I'm not able to reproduce any problem with this, but I wonder if you're getting confused by the way autoplace adjusts things to avoid collisions as you move? Or perhaps you have other elements in your score with a higher stacking order (see Appearance section of Properties panel) than the image, so they overlap the image and make it harder to select?

If you continue to have problems after verifying it isn't just one of those things, try making a screen recording and uploading that here.

@cadiz2
Copy link

cadiz2 commented Sep 18, 2024

I can confirm that this fix (#24353) does not resolve the issue satisfactorily in the 4.4.2.
With a new created default flute score (so nothing to deal with autoplace, stacking order), see what happens on the GIF below (.jpg file, 11,8 Ko size)
Moved once with the mouse, on the second attempt the image sticks in place and causes the score to move. In short, the fix needs improvement.

Video 2

@MarcSabatella
Copy link
Contributor

Hmm, I was able to reproduce but only after a couple of dozen failures (failures to reproduce the problem, that is). Like, it works 90%+ of the time but every once in a while fails. But once it fails for a given image, it seems it will never work again.

In the couple of cases where I was to reproduce it, the problem isn't about dragging, exactly - the image isn't even selectable. Try to click on it and Properties still shows the content it does when nothing is selected, instead of the content you expect with an image selected. Or, if it's overalying a staff, clicking it selects the content underneath.

After a whole lot of experimentation, I have some additional observations

It actually appears that at least some of the times you drag the image, a new "phantom" image is created as well. Although you can't see or click on them, you can select these phantom images via Alt+Left/Right. For instance, if the original image is added to the title frame, and then dragged away, click the composer then press Alt+Right (or possibly Alt+Left) and it should reach the image. I can drag an image dozens of times and this still works, but at some point, I get into the bugged state. And then Alt+Left/Right start showing me all these extra invisible images.

At least sometimes. I've also managed to get into a state where the image isn't selectable by clicking but is via Alt+Left/rRight and there are not any phantom images. But then, oddly, if I Alt+Tab away from the window then come back, the image is sometimes selectable again.

It still works as expected 90% of the time (more than that, really), but when it fails, it fails pretty strangely!

@zacjansheski
Copy link
Contributor

Doing regression checking on this on MacOS

4.4.0 - image gets stuck or just wants to resize
4.4.1 - image resizes uncontrollably
4.4.2 - image gets stuck
4.4.3 - nightly this issue seems much better

@MatthieuS-ctrl Can you also try the nightly and see if this is improved (or even resolved?)

video1468034840.mp4

@MarcSabatella
Copy link
Contributor

Linux nightlies seems broken or disabled? No 4.4.3 build, no other updates since the 17th.

@MatthieuS-ctrl
Copy link
Author

work ok with
MuseScore Studio version (64-bit): 4.3.2-241630831, revision: github-musescore-musescore-22b46f2

problem with
MuseScore Studio version (64-bit): 4.4.0-242390800, revision: github-musescore-musescore-0fcd11b

still the problem with
MuseScore Studio version (64-bit): 4.4.1-242490810, revision: github-musescore-musescore-0b3dd00

@zacjansheski
Copy link
Contributor

@MatthieuS-ctrl I was asking if it is fixed in nightly for you (it seems much better for me) https://musescore.org/en/nightly-builds

@MarcSabatella Linux Nightly builds are fixed now by #24825

@MatthieuS-ctrl
Copy link
Author

@zacjansheski sorry my english is not very good .....

I've installed this file:

MuseScoreNightly-latest-master-x86_64-portable.exe | 2024-09-20 03:31 | 95M |  

which is version

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore Studio version (64-bit): 4.5.0-242640305, revision: github-musescore-musescore-1aec102

Imported picture is stuck after one click. Then all the score is moving.

I click on the score, and on the picture again, so I can move the picture one more time.

After that more try, no way to move the picture again.

@zacjansheski zacjansheski added regression MS4 Regression on a prior release P1 Priority: High and removed needs review The issue needs review to set priority, fix version or change status etc. regression MS3 Regression from MS3 (3.6.2) labels Sep 20, 2024
@zacjansheski zacjansheski removed their assignment Sep 20, 2024
@bkunda
Copy link

bkunda commented Sep 23, 2024

Just a bit of extra info: I was able to reproduce this, but then I could re-select my picture if I made a change to the score layout (e.g. by inserting a system break). But it quickly broke again, particularly after clicking and dragging the score itself.

@mathesoncalum mathesoncalum moved this from Issues to fix to Needs porting in MuseScore Studio 4.4.3 Oct 3, 2024
@mathesoncalum mathesoncalum moved this from Needs porting to In Progress in MuseScore Studio 4.4.3 Oct 3, 2024
mike-spa added a commit that referenced this issue Oct 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Needs porting in MuseScore Studio 4.4.3 Oct 4, 2024
mathesoncalum added a commit that referenced this issue Oct 8, 2024
Fix #24791: Only allow image resizing with grips (4.4.3 port)
@mathesoncalum mathesoncalum moved this from Needs porting to Done in MuseScore Studio 4.4.3 Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High regression MS4 Regression on a prior release UX/interaction
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants