Skip to content

Commit f478adb

Browse files
committed
Replace DateTime with Carbon, add setTestNow
1 parent 3a20d62 commit f478adb

File tree

4 files changed

+11
-9
lines changed

4 files changed

+11
-9
lines changed

phpunit.php

+2
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,5 @@
2626
*/
2727

2828
date_default_timezone_set('UTC');
29+
30+
Carbon\Carbon::setTestNow(Carbon\Carbon::now());

src/Illuminate/Queue/Failed/DatabaseFailedJobProvider.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php namespace Illuminate\Queue\Failed;
22

3-
use DateTime;
3+
use Carbon\Carbon;
44
use Illuminate\Database\ConnectionResolverInterface;
55

66
class DatabaseFailedJobProvider implements FailedJobProviderInterface {
@@ -51,7 +51,7 @@ public function __construct(ConnectionResolverInterface $resolver, $database, $t
5151
*/
5252
public function log($connection, $queue, $payload)
5353
{
54-
$failed_at = new DateTime;
54+
$failed_at = Carbon::now();
5555

5656
$this->getTable()->insert(compact('connection', 'queue', 'payload', 'failed_at'));
5757
}

tests/Database/DatabaseEloquentModelTest.php

+5-5
Original file line numberDiff line numberDiff line change
@@ -249,8 +249,8 @@ public function testTimestampsAreReturnedAsObjectsFromPlainDatesAndTimestamps()
249249
public function testTimestampsAreReturnedAsObjectsOnCreate()
250250
{
251251
$timestamps = array(
252-
'created_at' => new DateTime,
253-
'updated_at' => new DateTime
252+
'created_at' => Carbon\Carbon::now(),
253+
'updated_at' => Carbon\Carbon::now()
254254
);
255255
$model = new EloquentDateModelStub;
256256
Illuminate\Database\Eloquent\Model::setConnectionResolver($resolver = m::mock('Illuminate\Database\ConnectionResolverInterface'));
@@ -266,8 +266,8 @@ public function testTimestampsAreReturnedAsObjectsOnCreate()
266266
public function testDateTimeAttributesReturnNullIfSetToNull()
267267
{
268268
$timestamps = array(
269-
'created_at' => new DateTime,
270-
'updated_at' => new DateTime
269+
'created_at' => Carbon\Carbon::now(),
270+
'updated_at' => Carbon\Carbon::now()
271271
);
272272
$model = new EloquentDateModelStub;
273273
Illuminate\Database\Eloquent\Model::setConnectionResolver($resolver = m::mock('Illuminate\Database\ConnectionResolverInterface'));
@@ -372,7 +372,7 @@ public function testDeleteProperlyDeletesModelWhenSoftDeleting()
372372
$model->setSoftDeleting(true);
373373
$query = m::mock('stdClass');
374374
$query->shouldReceive('where')->once()->with('id', 1)->andReturn($query);
375-
$query->shouldReceive('update')->once()->with(array('deleted_at' => $model->fromDateTime(new DateTime)));
375+
$query->shouldReceive('update')->once()->with(array('deleted_at' => $model->fromDateTime(Carbon\Carbon::now())));
376376
$model->expects($this->once())->method('newQuery')->will($this->returnValue($query));
377377
$model->expects($this->once())->method('touchOwners');
378378
$model->exists = true;

tests/Database/DatabaseEloquentRelationTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ public function testTouchMethodUpdatesRelatedTimestamps()
2121
$relation = new HasOne($builder, $parent, 'foreign_key', 'id');
2222
$related->shouldReceive('getTable')->andReturn('table');
2323
$related->shouldReceive('getUpdatedAtColumn')->andReturn('updated_at');
24-
$related->shouldReceive('freshTimestampString')->andReturn(new DateTime);
25-
$builder->shouldReceive('update')->once()->with(array('updated_at' => new DateTime));
24+
$related->shouldReceive('freshTimestampString')->andReturn(Carbon\Carbon::now());
25+
$builder->shouldReceive('update')->once()->with(array('updated_at' => Carbon\Carbon::now()));
2626

2727
$relation->touch();
2828
}

0 commit comments

Comments
 (0)