Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests sometimes generate a time-out error #59

Closed
unzvfu opened this issue Aug 1, 2017 · 2 comments
Closed

Unit tests sometimes generate a time-out error #59

unzvfu opened this issue Aug 1, 2017 · 2 comments

Comments

@unzvfu
Copy link

unzvfu commented Aug 1, 2017

First noticed during assessment of #56.
The tests sometimes pass, sometimes fail. Failure is always due to exceeding the 10m time limit.
Example: https://travis-ci.org/n1analytics/javallier/jobs/257569748
Failures are usually on OpenJDK7, seen once on OracleJDK7, never on OracleJDK8.

One idea: Some tests use the system entropy (cf. #58), which will block when the random material is depleted.

@unzvfu
Copy link
Author

unzvfu commented Aug 22, 2017

An experiment that removes use of SecureRandom seems to fix the problem: https://travis-ci.org/n1analytics/javallier/builds/267016134
Unfortunately, modifying the system so that it is parameterised by PRNG will be a big job (cf. #58 (comment) )

@unzvfu unzvfu removed their assignment Aug 22, 2017
@unzvfu
Copy link
Author

unzvfu commented Sep 5, 2017

This is apparently fixed by #62.

@unzvfu unzvfu closed this as completed Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant