Skip to content

Commit

Permalink
Update version for release
Browse files Browse the repository at this point in the history
  • Loading branch information
@TMRh20
TMRh20 committed Oct 23, 2023
1 parent 32e3133 commit 368a8ef
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion library.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"type": "git",
"url": "https://github.com/nRF24/RF24Ethernet.git"
},
"version": "1.6.13",
"version": "1.6.14",
"dependencies":
[
{
Expand Down
2 changes: 1 addition & 1 deletion library.properties
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name=RF24Ethernet
version=1.6.13
version=1.6.14
author=TMRh20
maintainer=TMRh20
sentence=OSI layer 4/5 (TCP/IP) wireless/radio IoT mesh networks for nRF24L01(+)
Expand Down

5 comments on commit 368a8ef

@TMRh20
Copy link
Member Author

@TMRh20 TMRh20 commented on 368a8ef Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why the linter is failing on this commit... As usual my cpp formatting is probably off somewhere...

@TMRh20
Copy link
Member Author

@TMRh20 TMRh20 commented on 368a8ef Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I found where Github actually shows the error messages, which is nice, but the problem is I formatted using clang on VSCode and am not sure what the linter isn't running. If I try to use the clang executable from https://llvm.org/builds/ or on raspberry pi I get an error message about invalid arguments lol. Not sure how to match the formatting... @2bndy5 How are you formatting?

@2bndy5
Copy link
Member

@2bndy5 2bndy5 commented on 368a8ef Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-format automatically looks for a .clang-format file (either in folder with source or a parent folder of the source). The .clang-format file is the linter's config file. Using a config file means we don't have to pass a customized --style arg to clang-format, but the --style can still be used to override the options set in the config file.

The version of clang-format used is actually very important as there are significant behavioral changes between clang versions. Our CI uses v12. You can find out what version you're running with

clang-format --version

If clang-format v12 is installed (and should be added to PATH during install), then to formatting a file in CLI

on Linux

clang-format-12 RF24Client.cpp

on windows

clang-format RF24Client.cpp

@2bndy5
Copy link
Member

@2bndy5 2bndy5 commented on 368a8ef Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking about upgrading clang-format to v14 (or newer) since Visual Studio Build Tools (essential to compiling C/C++ on Windows) expects a certain version of clang as a minimum supported version.

@2bndy5
Copy link
Member

@2bndy5 2bndy5 commented on 368a8ef Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed formatting in RF24Client.cpp. It was just some indentation changes, but it looks a bit confusing to the naked eye because the else if statement is spread out over 2 differently indented lines...

I also modified the PIO CI triggers to run every time there are changes to the library source (at least the ones that aren't copied from the old UIP lib).

Should be good to release now. If you want to upgrade the clang-format version we use, raise an issue in our .github repo (because all our format checks are using the same reusable workflow, cpp_lint.yaml). The .clang-format files in our repos are all the same copied file, so I might have to update those.

Please sign in to comment.