Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renewAddress to MQTT examples if connect fails #49

Merged
merged 7 commits into from
Jul 7, 2024

Conversation

TMRh20
Copy link
Member

@TMRh20 TMRh20 commented Jul 6, 2024

With the recent changes to RF24Mesh involving the checkConnection() function now verifying connectivity only with its parent node, additional checks can help maintain connectivity when direct connectivity to the master node is required.

  • Update MQTT examples to renew their address if unable to connect to the MQTT server

- Update MQTT examples to renew their address if unable to connect to the MQTT server
@TMRh20 TMRh20 requested a review from 2bndy5 July 6, 2024 09:05
Copy link
Contributor

github-actions bot commented Jul 6, 2024

Memory usage change @ b0ae98a

Board flash % RAM for global variables %
arduino:avr:nano 🔺 0 - +28 0.0 - +0.09 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 💚 -8 - 0 -0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Getting_Started_SimpleClient_Mesh
flash
% examples/Getting_Started_SimpleClient_Mesh
RAM for global variables
% examples/Getting_Started_SimpleServer_Mesh
flash
% examples/Getting_Started_SimpleServer_Mesh
RAM for global variables
% examples/InteractiveServer_Mesh
flash
% examples/InteractiveServer_Mesh
RAM for global variables
% examples/MQTT/mqtt_basic
flash
% examples/MQTT/mqtt_basic
RAM for global variables
% examples/MQTT/mqtt_basic_2
flash
% examples/MQTT/mqtt_basic_2
RAM for global variables
% examples/MQTT/mqtt_basic_no_blk
flash
% examples/MQTT/mqtt_basic_no_blk
RAM for global variables
% examples/SimpleClient_Mesh
flash
% examples/SimpleClient_Mesh
RAM for global variables
%
arduino:avr:nano 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 28 0.09 0 0.0 28 0.09 0 0.0 N/A N/A N/A N/A 0 0.0 0 0.0
arduino:samd:mkrzero 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -8 -0.0 0 0.0 -8 -0.0 0 0.0 N/A N/A N/A N/A 0 0.0 0 0.0
Click for full report CSV
Board,examples/Getting_Started_SimpleClient_Mesh<br>flash,%,examples/Getting_Started_SimpleClient_Mesh<br>RAM for global variables,%,examples/Getting_Started_SimpleServer_Mesh<br>flash,%,examples/Getting_Started_SimpleServer_Mesh<br>RAM for global variables,%,examples/InteractiveServer_Mesh<br>flash,%,examples/InteractiveServer_Mesh<br>RAM for global variables,%,examples/MQTT/mqtt_basic<br>flash,%,examples/MQTT/mqtt_basic<br>RAM for global variables,%,examples/MQTT/mqtt_basic_2<br>flash,%,examples/MQTT/mqtt_basic_2<br>RAM for global variables,%,examples/MQTT/mqtt_basic_no_blk<br>flash,%,examples/MQTT/mqtt_basic_no_blk<br>RAM for global variables,%,examples/SimpleClient_Mesh<br>flash,%,examples/SimpleClient_Mesh<br>RAM for global variables,%
arduino:avr:nano,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,28,0.09,0,0.0,28,0.09,0,0.0,N/A,N/A,N/A,N/A,0,0.0,0,0.0
arduino:samd:mkrzero,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-8,-0.0,0,0.0,-8,-0.0,0,0.0,N/A,N/A,N/A,N/A,0,0.0,0,0.0

- Add non-blocking connect MQTT example
- Remove unused variable `test`
- Put timer calculations outside loops
- Add new example file to docs
github-actions[bot]

This comment was marked as resolved.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot dismissed their stale review July 6, 2024 19:45

outdated suggestion

@TMRh20 TMRh20 requested a review from 2bndy5 July 7, 2024 03:56
@2bndy5

This comment was marked as resolved.

@2bndy5

This comment was marked as resolved.

@2bndy5 2bndy5 force-pushed the mqtt_examples_renew branch from f634983 to a341c88 Compare July 7, 2024 12:54
Copy link
Member

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TMRh20 TMRh20 merged commit f5980c0 into master Jul 7, 2024
63 checks passed
@TMRh20 TMRh20 deleted the mqtt_examples_renew branch July 7, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants