Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websocket: inline the aios #1974

Merged
merged 1 commit into from
Dec 7, 2024
Merged

websocket: inline the aios #1974

merged 1 commit into from
Dec 7, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 7, 2024

This covers both the ttransport and the supplemental layers.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

This covers both the ttransport and the supplemental layers.
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 97.26027% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.84%. Comparing base (f8a314e) to head (32c78f7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/sp/transport/ws/websocket.c 96.55% 1 Missing ⚠️
src/supplemental/websocket/websocket.c 97.72% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
- Coverage   81.96%   81.84%   -0.12%     
==========================================
  Files          95       95              
  Lines       24074    24068       -6     
  Branches     3209     3206       -3     
==========================================
- Hits        19732    19699      -33     
- Misses       4269     4298      +29     
+ Partials       73       71       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 32c78f7 into main Dec 7, 2024
16 of 19 checks passed
@gdamore gdamore deleted the websocket-aio branch December 7, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant