Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output filename of harmony.util.download does not match docstring description #51

Open
asjohnston-asf opened this issue Oct 28, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation story New feature written as a user story

Comments

@asjohnston-asf
Copy link

asjohnston-asf commented Oct 28, 2024

The docstring for harmony_service_lib.util.download() says "Downloads the given URL to the given destination directory, using the basename of the URL as the filename in the destination directory", but the implementation via harmony.util._filename() instead uses a random sha256 hash as the filename stem.

I'd prefer the former approach. I want the output file of my service to be named based on the input granule, and the pystac.Item input only includes the name of the input granule in the asset filenames.

@chris-durbin chris-durbin added documentation Improvements or additions to documentation story New feature written as a user story labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation story New feature written as a user story
Projects
None yet
Development

No branches or pull requests

2 participants