Skip to content
This repository was archived by the owner on Sep 26, 2020. It is now read-only.

Nuke log in preference of hclog #1

Open
canesin opened this issue Mar 14, 2020 · 2 comments
Open

Nuke log in preference of hclog #1

canesin opened this issue Mar 14, 2020 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@canesin
Copy link
Contributor

canesin commented Mar 14, 2020

Latest Raft versions will not compile with current log implementation.
We need to replace use of log across the app (not that big of a deal).

hclog: https://github.com/hashicorp/go-hclog

@canesin canesin self-assigned this Mar 14, 2020
@canesin canesin added the enhancement New feature or request label Mar 14, 2020
@guidog
Copy link

guidog commented Mar 17, 2020

Hi!

The code doesn't compile due to the logging type mismatch, wouldn't call that an enhancement.

I made master compile using hclog and fixed some other bugs so the tests can be executed.
Unfortunately some code got reformatted, so the resulting PR contains more then the bare minimum of changes.

Are you interested in a PR?

Cheers
Guido

@canesin canesin added the bug Something isn't working label Mar 17, 2020
@canesin
Copy link
Contributor Author

canesin commented Mar 17, 2020

Hi @guidog sure! Feel free to issue it. I was planning on doing it today so I might work on other items.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants