Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UG for trademark and NatCap branding #133

Merged
merged 8 commits into from
Sep 22, 2023
Merged

Update UG for trademark and NatCap branding #133

merged 8 commits into from
Sep 22, 2023

Conversation

phargogh
Copy link
Member

@phargogh phargogh commented Sep 20, 2023 •
edited
Loading

Per a request from the comms team, this PR updates the partner logos and slightly updates a few styles and fonts in keeping with NatCap branding in addition to adding the ® in a few places.

There are a few functional things I wanted to point out as an FYI for the whole software team:

  1. Sphinx really doesn't do anything intelligent with images like logos, so I added a script to handle uniform scaling and padding. When we add a partner org, we should run the script on the logo they give us and commit the resulting image.
  2. The _templates directory now contains jinja overrides for our theme. Right now it's pretty simple (just adding fonts and related stylesheets) but could be extended as needed for future theme modifications. The Makefile now excludes dirs prefixed with _

Anyways, happy to discuss!

Here's a preview of changes:

Screenshot 2023-09-20 at 4 40 28 PM

@phargogh
Updating UG for branding.
0ffbe66 
Changes include:
  * Installing branded fonts and using them throughout.
  * Replacing partner banner with grid of individual partner logos.
  * Adding a script to resample and position partner logos for
    uniformity.
  * Adding the NatCap logo to the front page
  * Adding registered trademark ® to a few obvious places
  * Adding attribution guidelines, which includes links to the logo and
    trademark and acceptable use policy on the website (consistent with
    how Python does this)
@phargogh
Using dark lagunita blue and cardinal red.
48cfde3
@phargogh
Moving templates dir and adding NatCap logo file.
28f040b
@phargogh
Exclude dirs with leading underscore from build.
69791ff
@phargogh
Moving templates dir, shuffling logos.
b9eff36
dcdenu4
dcdenu4 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phargogh!

davemfish
davemfish reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@davemfish davemfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, James, this all sounds good. My only feedback is that it feels like I'm getting blasted with "InVEST" in that upper-left corner. Now that we have the logo there, do we still need the "InVEST" title right below it? Or alternatively, maybe the InVEST logo should replace the image of the lake?

Anyway, no big deal either way.

@dcdenu4
Copy link
Member

dcdenu4 commented Sep 21, 2023

@davemfish, I feel the same way and your comment made me chuckle. It's like those flashing ads: invest, InVEST, INVEST!!!

I know it's a pain to work in this framework, but I wouldn't mind seeing the logo in the upper left, removing the "InVEST" home button below, and is it possible to center the "InVEST User Guide" title?

@dcdenu4 dcdenu4 self-requested a review September 21, 2023 13:51
@davemfish
Copy link
Contributor

and is it possible to center the "InVEST User Guide" title?

This title is left-aligned with the body of text below, there's just a lot of space in between now with the logos. But on other pages, like a model chapter, it probably looks good with the left-alignment.

@phargogh
Copy link
Member Author

Thanks for the comments @davemfish and @dcdenu4 !

Although the theme is supposed to be able to hide the brand name below the logo through an option in conf.py, that wasn't working for me. This is now controlled with some custom CSS. I also added some custom CSS to center-align the UG title, and confirmed that this change does not alter the alignment on other pages. Screenshots below as a demonstration.
Screenshot 2023-09-21 at 2 35 04 PM
Screenshot 2023-09-21 at 2 35 35 PM

emlys
emlys approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@emlys emlys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @phargogh

dcdenu4
dcdenu4 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@dcdenu4 dcdenu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phargogh, looks good.

@davemfish
Copy link
Contributor

Thanks for accommodating these nitpicky requests; looks great!

@davemfish davemfish merged commit c31e453 into main Sep 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemfish davemfish davemfish left review comments

@emlys emlys emlys approved these changes

@dcdenu4 dcdenu4 dcdenu4 approved these changes

Assignees

@dcdenu4 dcdenu4

@davemfish davemfish

@phargogh phargogh

@emlys emlys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phargogh @dcdenu4 @davemfish @emlys