Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove REDD scenario option from Carbon Storage and Sequestration model #1758

Open
jagoldstein opened this issue Jan 30, 2025 · 5 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for new members of the software team science request A request/proposal from within natcap related to science (rather than engineering)
Milestone

Comments

@jagoldstein
Copy link
Member

We should consider removing the REDD Scenario section. It confuses users and is redundant with the "Calculate Sequestration/Future LULC" option, AFAICT. @newtpatrol do you agree or am I missing some context?

And it might actually be better/more accurate to call the scenarios "Baseline" instead of "Current" and "Alternate" or "Other" or "Scenario" or something instead of "Future". This would signal that users can compare scenarios from the past with the current, or whatever they want (not limited to current and future only).

I created this issue in this repo because @emilyanndavis stated that she "suspect[s] it would affect more than the UI". Also, it looks like the invest-workbench repo was archived.

@jagoldstein jagoldstein added enhancement New feature or request workbench For issues relating to the workbench front-end of invest labels Jan 30, 2025
@davemfish
Copy link
Contributor

davemfish commented Jan 31, 2025

Thanks, @jagoldstein , this is the correct place for an issue like this. On hold until we have some consensus around it. The proposal makes sense to me though.

@davemfish davemfish added this to the 3.15.0 milestone Jan 31, 2025
@davemfish davemfish added good first issue Good for new members of the software team science request A request/proposal from within natcap related to science (rather than engineering) on hold There's a reason we're not working on this yet and removed workbench For issues relating to the workbench front-end of invest labels Jan 31, 2025
@newtpatrol
Copy link
Contributor

I've always wondered why we bother with the REDD scenario, for the same question of redundancy, and it makes it sound like the model is doing something fancy when it isn't. The User Guide says this, indicating that it just runs the sequestration calculation twice:

Based on these three LULC maps for current, baseline, and REDD policy scenarios, the carbon biophysical model produces rasters for total carbon storage for each of the three LULC maps, and two sequestration rasters for future and REDD scenarios.

And I'm not aware of anyone ever using this option. That said, removing it doesn't seem like any sort of priority in the grand scheme of things.

My more regular puzzlement comes with the output file naming. If the model is called "Storage and Sequestration", then why aren't the "tot_c" outputs named "storage" and the "delta" outputs named "sequestration"?

~ Stacie

@dcdenu4
Copy link
Member

dcdenu4 commented Jan 31, 2025

Hey @jagoldstein or @newtpatrol, do you think this is something mention and link to in our natcapsoftwaremodelin channel to see if anyone else has strong thoughts?

My more regular puzzlement comes with the output file naming. If the model is called "Storage and Sequestration", then why aren't the "tot_c" outputs named "storage" and the "delta" outputs named "sequestration"?

@newtpatrol , I think this could be a separate issue!

@dcdenu4
Copy link
Member

dcdenu4 commented Feb 4, 2025

@rmgriffin, @chrisnootenboom , and others were in favor for

And it might actually be better/more accurate to call the scenarios "Baseline" instead of "Current" and "Alternate" or "Other" or "Scenario" or something instead of "Future"

There was an additional suggestion of:

Also perhaps some clarity on how the Tons/pixels is calculated would be super (probably one or two sentences in the user guide would do)

My overall sense from the Slack discussion is that a majority of folks are in favor of dropping the REDD component and updating some terms to make scenario runs more intuitive.

@davemfish davemfish removed the on hold There's a reason we're not working on this yet label Feb 4, 2025
@rmgriffin
Copy link

I've always wondered why we bother with the REDD scenario, for the same question of redundancy, and it makes it sound like the model is doing something fancy when it isn't. The User Guide says this, indicating that it just runs the sequestration calculation twice:

Based on these three LULC maps for current, baseline, and REDD policy scenarios, the carbon biophysical model produces rasters for total carbon storage for each of the three LULC maps, and two sequestration rasters for future and REDD scenarios.

And I'm not aware of anyone ever using this option. That said, removing it doesn't seem like any sort of priority in the grand scheme of things.

My more regular puzzlement comes with the output file naming. If the model is called "Storage and Sequestration", then why aren't the "tot_c" outputs named "storage" and the "delta" outputs named "sequestration"?

~ Stacie

I could see renaming the model being the preferred route vs the outputs, as some scenarios could cause emissions versus sequestration. Maybe something like carbon "storage and change."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for new members of the software team science request A request/proposal from within natcap related to science (rather than engineering)
Projects
None yet
Development

No branches or pull requests

6 participants