Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbench: upgrade electron and puppeteer dependencies #1800

Open
emilyanndavis opened this issue Feb 20, 2025 · 0 comments
Open

Workbench: upgrade electron and puppeteer dependencies #1800

emilyanndavis opened this issue Feb 20, 2025 · 0 comments
Labels
workbench For issues relating to the workbench front-end of invest

Comments

@emilyanndavis
Copy link
Member

Since Electron releases a new major version every 8 weeks (in sync with every even-numbered major release of Chromium), the Workbench's electron dependency is now several major versions out of date. (Only the 3 most recent stable versions are officially supported, which means a release typically reaches EOL after 24 weeks, or 5–6 months.)

The puppeteer-core dependency is also a few major versions out of date.

Since both electron and puppeteer-core have Chromium dependencies that should be kept in sync, it makes sense to upgrade both packages in tandem to make sure they are compatible.

When I tried upgrading puppeteer-core (and electron, to a compatible version), the Workbench puppeteer test hangs (and eventually times out). There must be a breaking change introduced in puppeteer v22 (and possibly additional breaking changes in later versions), but I haven't been able to track it down yet.

Some references that may be useful:

@emilyanndavis emilyanndavis added the workbench For issues relating to the workbench front-end of invest label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workbench For issues relating to the workbench front-end of invest
Projects
None yet
Development

No branches or pull requests

1 participant