Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race in reading error from message batch #1733

Open
aldiesel opened this issue Nov 3, 2024 · 0 comments · May be fixed by #1743
Open

Race in reading error from message batch #1733

aldiesel opened this issue Nov 3, 2024 · 0 comments · May be fixed by #1743
Assignees
Labels
defect Suspected defect such as a bug or regression

Comments

@aldiesel
Copy link

aldiesel commented Nov 3, 2024

Observed behavior

type messageBatch has a race where the user can just check the error at any time, but there is no mutex on the read. Meanwhile any error like context ending will cause an error to be written.

Expected behavior

no race

Server and client version

client 1.37.0

Host environment

No response

Steps to reproduce

kill context and read error from message batch

@aldiesel aldiesel added the defect Suspected defect such as a bug or regression label Nov 3, 2024
@piotrpio piotrpio linked a pull request Dec 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Suspected defect such as a bug or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants