Skip to content

Commit a63db2c

Browse files
Some tiny improvements
1 parent 3125ca9 commit a63db2c

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

src/main/java/com/naturalprogrammer/spring/lemon/LemonController.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
import com.fasterxml.jackson.annotation.JsonView;
1919
import com.naturalprogrammer.spring.lemon.domain.AbstractUser;
20-
import com.naturalprogrammer.spring.lemon.domain.AbstractUser.SignupView;
20+
import com.naturalprogrammer.spring.lemon.domain.AbstractUser.SignupInput;
2121
import com.naturalprogrammer.spring.lemon.domain.ChangePasswordForm;
2222
import com.naturalprogrammer.spring.lemon.util.LemonUtil;
2323

@@ -76,7 +76,7 @@ public Map<String, Object> getContext() {
7676
*/
7777
@PostMapping("/users")
7878
@ResponseStatus(HttpStatus.CREATED)
79-
public U signup(@RequestBody @JsonView(SignupView.class) U user) {
79+
public U signup(@RequestBody @JsonView(SignupInput.class) U user) {
8080

8181
log.debug("Signing up: " + user);
8282
lemonService.signup(user);

src/main/java/com/naturalprogrammer/spring/lemon/LemonProperties.java

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import java.util.Map;
44

5+
import javax.validation.constraints.Size;
6+
57
import org.springframework.boot.context.properties.ConfigurationProperties;
68
import org.springframework.context.annotation.Configuration;
79
import org.springframework.validation.annotation.Validated;
@@ -28,6 +30,7 @@ public class LemonProperties {
2830
/**
2931
* Secret string used for encrypting remember-me tokens
3032
*/
33+
@Size(min=6)
3134
private String rememberMeKey;
3235

3336
/**

src/main/java/com/naturalprogrammer/spring/lemon/domain/AbstractUser.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -69,16 +69,16 @@ public interface UpdateValidation {}
6969
public interface ChangeEmailValidation {}
7070

7171
// JsonView for Sign up
72-
public interface SignupView {}
72+
public interface SignupInput {}
7373

7474
// email
75-
@JsonView(SignupView.class)
75+
@JsonView(SignupInput.class)
7676
@UniqueEmail(groups = {SignUpValidation.class})
7777
@Column(nullable = false, unique=true, length = EMAIL_MAX)
7878
protected String email;
7979

8080
// password
81-
@JsonView(SignupView.class)
81+
@JsonView(SignupInput.class)
8282
@Password(groups = {SignUpValidation.class, ChangeEmailValidation.class})
8383
@Column(nullable = false) // no length because it will be encrypted
8484
protected String password;
@@ -106,7 +106,7 @@ public interface SignupView {}
106106

107107
// holds reCAPTCHA response while signing up
108108
@Transient
109-
@JsonView(SignupView.class)
109+
@JsonView(SignupInput.class)
110110
@Captcha(groups = {SignUpValidation.class})
111111
private String captchaResponse;
112112

src/main/java/com/naturalprogrammer/spring/lemon/mail/MailSender.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@
99
*/
1010
public interface MailSender {
1111

12-
public void send(String to, String subject, String body) throws MessagingException;
12+
void send(String to, String subject, String body) throws MessagingException;
1313

1414
}

0 commit comments

Comments
 (0)