Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of load_local_env_vars #170

Closed
lorenyu opened this issue Jun 9, 2023 · 1 comment
Closed

Get rid of load_local_env_vars #170

lorenyu opened this issue Jun 9, 2023 · 1 comment
Labels
enhancement New feature or request maintenance

Comments

@lorenyu
Copy link
Contributor

lorenyu commented Jun 9, 2023 •
edited
Loading

I think it's kind of weird/brittle to load_local_env_vars in production code. While working on integrating template-infra and template-application-flask I noticed the local env vars were being set in the cloud deployed version of the app. I believe it's because the ENVIRONMENT variable wasn't set. But that's kind of a brittle thing to rely on.
@lorenyu lorenyu added enhancement New feature or request maintenance labels Jun 9, 2023
@lorenyu
Copy link
Contributor Author

lorenyu commented Jun 9, 2023

Duplicate of #136

@lorenyu lorenyu marked this as a duplicate of #136 Jun 9, 2023
@lorenyu lorenyu closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lorenyu