Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ENVIRONMENT as env var to service container #305

Closed
lorenyu opened this issue Jun 9, 2023 · 3 comments
Closed

Set ENVIRONMENT as env var to service container #305

lorenyu opened this issue Jun 9, 2023 · 3 comments
Labels
workflow: good first issue Good for newcomers

Comments

@lorenyu
Copy link
Contributor

lorenyu commented Jun 9, 2023

I discovered that the flask template relies on an environment variable called ENVIRONMENT being set (e.g. ENVIRONMENT="dev", ENVIRONMENT="prod"). While not an ideal dependency, we should still set it anyways from infra point of view.

@lorenyu lorenyu added the workflow: good first issue Good for newcomers label Jun 9, 2023
@lorenyu
Copy link
Contributor Author

lorenyu commented Jun 9, 2023

higher priority since flask template currently relies on this

@lorenyu
Copy link
Contributor Author

lorenyu commented Jun 9, 2023

actually on second thought i think we should probably prioritize navapbc/template-application-flask#136 and deprioritize this ticket. i'm actually still on the fence as to whether we should do this at all.

@lorenyu
Copy link
Contributor Author

lorenyu commented Dec 22, 2023

don't think we should do this unless there's a real need for it. in general want to discourage from using the environment as part of application logic, to stay true to 12factorapp principles

@lorenyu lorenyu closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow: good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant