Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should region start and end values support category names? #3920

Closed
Squirrelsnuts opened this issue Nov 25, 2024 · 1 comment
Closed

Should region start and end values support category names? #3920

Squirrelsnuts opened this issue Nov 25, 2024 · 1 comment
Labels
feature question

Comments

@Squirrelsnuts
Copy link

Description

When using x-axis regions with an x-axis whose type is category, should the region start and end values use category names like the grid.x.lines option? It appears to only support index values at the moment.

Steps to check or reproduce
@netil netil added the question label Nov 26, 2024
netil pushed a commit to netil/billboard.js that referenced this issue Jan 14, 2025
feat(region): Enhance regions accept category range
4ac2ae9 
- Enhance regions start/end to use category name values
- Reinforce documentation and demo

Ref naver#3920
@netil netil mentioned this issue Jan 14, 2025
Merged
@netil netil closed this as completed in 904e35b Jan 14, 2025
@netil
Copy link
Member

netil commented Jan 14, 2025

Hi @Squirrelsnuts, updated enhancement to regions option to be able specify start/end values with category names.

@netil netil added the feature label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@netil @Squirrelsnuts