third-party: move tommyds from spki/hashtable into third party folder and remove version from folder name

tommyds has not be used exclusively by spki for quite some time, it
therefore does not make sense to keep in under the spki directory.

Furthermore having the tommyds version in the folder name only makes
updating the lib more verbose and is not necessary for knowing the
current version since the version number is available in several places
within files of the library.

Author: mroethke

.codecov.yml

@@ -8,7 +8,7 @@ coverage:
   range: "50...80"
 
   ignore:
-  - rtrlib/spki/hashtable/tommyds-2.2/.*
+  - third-party/
   - tests/*
 
   status: {}

CMakeLists.txt

@@ -32,6 +32,8 @@ endif(CMAKE_BUILD_TYPE STREQUAL Debug)
 
 include_directories(.)
 
+add_subdirectory(third-party)
+
 find_package(codecov)
 
 find_package(Threads REQUIRED)
@@ -45,7 +47,7 @@ set(RTRLIB_SRC rtrlib/rtr_mgr.c rtrlib/lib/utils.c rtrlib/lib/alloc_utils.c rtrl
     rtrlib/lib/ip.c rtrlib/lib/ipv4.c rtrlib/lib/ipv6.c rtrlib/lib/log.c
     rtrlib/pfx/trie/trie.c rtrlib/pfx/trie/trie-pfx.c rtrlib/transport/transport.c
     rtrlib/transport/tcp/tcp_transport.c rtrlib/rtr/rtr.c rtrlib/rtr/packets.c
-    rtrlib/spki/hashtable/ht-spkitable.c rtrlib/spki/hashtable/tommyds-2.2/tommy.c)
+    rtrlib/spki/hashtable/ht-spkitable.c ${tommyds})
 set(RTRLIB_LINK ${RT_LIB} ${CMAKE_THREAD_LIBS_INIT})
 
 find_package(LibSSH 0.5.0 QUIET)

rtrlib/rtr_mgr_private.h

@@ -10,7 +10,7 @@
 #ifndef RTR_MGR_PRIVATE
 #define RTR_MGR_PRIVATE
 #include "rtrlib/rtr_mgr.h"
-#include "rtrlib/spki/hashtable/tommyds-2.2/tommylist.h"
+#include "third-party/tommyds/tommylist.h"
 
 struct tommy_list_wrapper {
 	tommy_list list;

rtrlib/spki/hashtable/ht-spkitable_private.h

@@ -10,8 +10,8 @@
 #define RTR_HT_SPKITABLE_PRIVATE_H
 
 #include "rtrlib/spki/spkitable_private.h"
-#include "rtrlib/spki/hashtable/tommyds-2.2/tommyhashlin.h"
-#include "rtrlib/spki/hashtable/tommyds-2.2/tommylist.h"
+#include "third-party/tommyds/tommyhashlin.h"
+#include "third-party/tommyds/tommylist.h"
 
 typedef int (*hash_cmp_fp)(const void *arg, const void *obj);
 

scripts/travis.sh

@@ -23,7 +23,7 @@ function run_command {
 
 function checkpatch {
 	git diff $TRAVIS_BRANCH '*.[ch]' > /tmp/patch
-	run_command scripts/checkpatch.pl --terse --no-tree --strict --show-types /tmp/patch
+	run_command scripts/checkpatch.pl --ignore FILE_PATH_CHANGES,PREFER_KERNEL_TYPES,CONST_STRUCT,OPEN_BRACE,SPDX_LICENSE_TAG,OPEN_ENDED_LINE,UNNECESSARY_PARENTHESES --terse --no-tree --strict --show-types /tmp/patch
 	ret=$?
 	if [ $ret != 0]; then
 		cat -n /tmp/patch

tests/test_dynamic_groups.c

@@ -5,7 +5,7 @@
 
 #include "rtrlib/rtrlib.h"
 #include "rtrlib/rtr_mgr_private.h"
-#include "rtrlib/spki/hashtable/tommyds-2.2/tommylist.h"
+#include "third-party/tommyds/tommylist.h"
 
 const int connection_timeout = 20;
 enum rtr_mgr_status connection_status = -1;

third-party/CMakeLists.txt

@@ -0,0 +1 @@
+set(tommyds "${CMAKE_CURRENT_SOURCE_DIR}/tommyds/tommy.c" PARENT_SCOPE)