Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompileToRawBinary does not handle OpCode::Type::MultiplyAdd #68

Open
Wunkolo opened this issue Jun 28, 2023 · 0 comments
Open

CompileToRawBinary does not handle OpCode::Type::MultiplyAdd #68

Wunkolo opened this issue Jun 28, 2023 · 0 comments

Comments

@Wunkolo
Copy link

Wunkolo commented Jun 28, 2023

Calling nihstro::InlineAsm::CompileToRawBinary with an OpCode::Id::MAD instruction causes an Unknown instruction exception to throw.

nihstro/include/nihstro/inline_assembly.h

Lines 400 to 402 in e924e21

default:
throw "Unknown instruction";

OpCode::Id::MAD is a OpCode::Type::MultiplyAdd which is unhandled by the switch-case and uses the exception-throwing default:-case.
luc-git pushed a commit to luc-git/citra that referenced this issue Oct 9, 2023
@Wunkolo @luc-git
shader_jit/tests: Add additional shader-jit tests (#6648)
b8e7341 
* shader_jit/tests: Add support for multiple inputs

Allows for multiple `Vec4f` inputs for each run

* shader_jit/tests: Add additional shader-jit tests

Add some more expansive tests for each of the shader-instructions for
regression-testing.  `MAD`/`MADI` is not added due to an upstream bug in
nihstro:

neobrain/nihstro#68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Wunkolo