Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid.Row: Create a PoC #6327

Open
tobiu opened this issue Jan 28, 2025 · 1 comment
Open

grid.Row: Create a PoC #6327

tobiu opened this issue Jan 28, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@tobiu
Copy link
Collaborator

tobiu commented Jan 28, 2025

I am just brainstorming about a new concept: should i create a component (class) for grid / table rows

In short: when we change a record, we send the vdom & vnode of the entire view (the mounted / painted part) to the vdom worker, which is quite the overhead.

We could just send the row fraction to the vdom worker, but then still the entire view would be locked for other updates
so updating multiple records would get delayed a lot. component.Base / container.Base has all the logic we need => updating in parallel & parent locking depending on the depth.

However, there needs to be a smart row cycling logic. imagine a grid with 50k rows => we must not even think about creating 50k row component instances. so only instances for painted rows and re-using instances when cycling (scrolling).

I will create a new feature branch for this story. grid.View might need to extend container.Base in this case.

Inside the current version:

store.getAt(0).set({firstname: 'foo'});
store.getAt(1).set({firstname: 'bar'});

The first record change would send the view vdom to the vdom worker and lock the view for updates. The second change would wait until the first update cycle is finished. It would most likely still end up inside the same animation frame.

However, in case we update a LOT of records, the impact grows. And, after all, neo is meant for high performance use cases.

@rwaters Thoughts on this one?

@tobiu tobiu added the enhancement New feature or request label Jan 28, 2025
@tobiu tobiu self-assigned this Jan 28, 2025
@tobiu
Copy link
Collaborator Author

tobiu commented Jan 29, 2025

more thoughts on this one:

If i update 50 records in a row, the first record change would trigger a view update. probably all other 49 would end up combined inside the next update cycle. the more changes there are, the faster the current method might be. needs benchmarking though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant