Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend STORAGE_BACKEND to support swift #14554

Closed
XioNoX opened this issue Dec 18, 2023 · 5 comments · Fixed by #16319
Closed

Extend STORAGE_BACKEND to support swift #14554

XioNoX opened this issue Dec 18, 2023 · 5 comments · Fixed by #16319
Assignees
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@XioNoX
Copy link
Contributor

XioNoX commented Dec 18, 2023

NetBox version

3.2

Feature type

Change to existing functionality

Proposed functionality

Netbox currently supports django-storages through the STORAGE_CONFIG and STORAGE_BACKEND.

I'd like to extend it to support https://github.com/dennisv/django-storage-swift which work overall the same way as django-storages so the changes should be minimal.

I already have a PoC over there https://gerrit.wikimedia.org/r/c/operations/software/netbox/+/980908 its not tested yet but will be if this feature request is accepted.

(And yes, we need to upgrade to 3.7).

Use case

django-storages unfortunately doesn't support Openstack SWIFT as backend. As it's a popular storage platform it seems beneficial to all Netbox users.
We're currently using SWIFT through some custom/internal Netbox patches, so it works. Here we would like to streamline it and make it available to all.

Database changes

No response

External dependencies

If used, django-storage-swift will obviously be needed :)

@XioNoX XioNoX added the type: feature Introduction of new functionality to the application label Dec 18, 2023
@jeffgdotorg jeffgdotorg added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Dec 19, 2023
@jeffgdotorg
Copy link
Contributor

Thanks for the FR, and particularly for the Gerrit link. There's clear value in this work, and the implementation is straightforward. I think we're leaning toward acceptance, but I want to pull on one loose thread.

I'm slightly concerned about the long-term viability of django-storage-swift, given its maintainer's low level of activity. I'm curious whether you've explored going one hop further upstream and proposing to enhance django-storages to add Swift support. The leverage there would be even greater.

@XioNoX
Copy link
Contributor Author

XioNoX commented Dec 20, 2023

Thanks for your reply,

I'm curious whether you've explored going one hop further upstream and proposing to enhance django-storages to add Swift support.

Not sure if you're suggesting that I, django-storage-swift or django-storages does the work 😄
I personally don't have the resources to do it.
I asked django-storage-swift over dennisv/django-storage-swift#112
There is only a mention of swift in jschneier/django-storages#148 so I don't think it's in their roadmap, but they could be opened to PRs.

So I'm not too optimistic something will happen in the short to medium term, that's why I'm wondering if we could move forward with this FR, and eventually roll it back if progress is made on the other front ?

@jeffgdotorg
Copy link
Contributor

I asked django-storage-swift over dennisv/django-storage-swift#112

Nicely advocated. Thanks for making that overture.

So I'm not too optimistic something will happen in the short to medium term, that's why I'm wondering if we could move forward with this FR, and eventually roll it back if progress is made on the other front ?

Go ahead and make a PR against our develop, please. We may have additional asks such as test coverage, but in principle I think it's likely we'll move forward.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Dec 20, 2023
@jeremystretch
Copy link
Member

@XioNoX would you still like to work on this?

@XioNoX
Copy link
Contributor Author

XioNoX commented May 22, 2024

Yep, I just noticed that django-storage-swift released a new version earlier this month, including my PR, so I will test then send a Netbox PR shortly.

@jeremystretch jeremystretch added the complexity: low Requires minimal effort to implement label May 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants