NetBox superuser cannot access System or Plugins pages without Staff status

[markkuleinio]

Deployment Type

Self-hosted

NetBox Version

v4.3.1

Python Version

3.11

Steps to Reproduce

1. Login with a user with superuser status
2. Remove Staff status (if present) from the user
3. Go to System - Plugins or System - System

Expected Behavior

Since the user is a superuser, access to the System and Plugins pages should be available.

Observed Behavior

"You do not have permission to access this page." so the superuser is not able to access System or Plugins pages.

Related issues/discussions:
#15754 Removal of staff_only=True from Admin menu items (completed)
#16137 Remove the is_staff field from the user model (open)
#17010 Hide Admin menu section for non-admins (open)

[jnovinger]

This is due to this check:

netbox/netbox/core/views.py

Lines 343 to 346 in b6c8502

	class BaseRQView(UserPassesTestMixin, View):
	def test_func(self):
	return self.request.user.is_staff

Given related proposed changes in #16137 and #17010, we should discuss what check is appropriate here instead of is_staff.