Skip to content

Commit b822c83

Browse files
committed
google format and test fixes
1 parent 975b1d0 commit b822c83

File tree

10 files changed

+46
-70
lines changed

10 files changed

+46
-70
lines changed

netifi-spring-boot-autoconfigure/src/main/java/com/netifi/spring/boot/BrokerClientAutoConfiguration.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
import io.rsocket.transport.netty.client.WebsocketClientTransport;
3636
import java.util.List;
3737
import java.util.Optional;
38-
3938
import org.springframework.beans.factory.support.BeanDefinitionRegistryPostProcessor;
4039
import org.springframework.boot.autoconfigure.AutoConfigureBefore;
4140
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;

netifi-spring-boot-autoconfigure/src/main/java/com/netifi/spring/boot/BrokerClientMessagingAutoConfiguration.java

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
import io.rsocket.RSocketFactory;
3030
import io.rsocket.frame.SetupFrameFlyweight;
3131
import io.rsocket.transport.netty.server.TcpServerTransport;
32-
3332
import java.time.Duration;
3433
import java.util.Optional;
3534
import org.springframework.beans.factory.support.DefaultListableBeanFactory;
@@ -69,8 +68,7 @@ public MessageHandlerAcceptor messageHandlerAcceptor(
6968
DefaultListableBeanFactory factory,
7069
RSocketStrategies rSocketStrategies,
7170
BrokerClient brokerClient) {
72-
BrokerClientProperties.KeepAliveProperties keepalive =
73-
brokerClientProperties.getKeepalive();
71+
BrokerClientProperties.KeepAliveProperties keepalive = brokerClientProperties.getKeepalive();
7472
Duration tickPeriod = Duration.ofSeconds(keepalive.getTickPeriodSeconds());
7573
Duration ackTimeout = Duration.ofSeconds(keepalive.getAckTimeoutSeconds());
7674
int missedAcks = keepalive.getMissedAcks();
@@ -87,9 +85,7 @@ public MessageHandlerAcceptor messageHandlerAcceptor(
8785
"text/plain",
8886
"text/plain",
8987
Unpooled.EMPTY_BUFFER,
90-
Unpooled.EMPTY_BUFFER
91-
)
92-
);
88+
Unpooled.EMPTY_BUFFER));
9389
MessageHandlerAcceptor acceptor = new MessageHandlerAcceptor();
9490
acceptor.setRSocketStrategies(rSocketStrategies);
9591
acceptor
@@ -104,8 +100,7 @@ public MessageHandlerAcceptor messageHandlerAcceptor(
104100
properties.getName(), brokerClient, factory, rSocketStrategies));
105101

106102
brokerClient.addNamedRSocket(
107-
properties.getName(),
108-
acceptor.apply(connectionSetupPayload, STUB_RSOCKET));
103+
properties.getName(), acceptor.apply(connectionSetupPayload, STUB_RSOCKET));
109104

110105
return acceptor;
111106
}

netifi-spring-boot-autoconfigure/src/main/java/com/netifi/spring/boot/BrokerClientProperties.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -148,11 +148,10 @@ public static final class Tags {}
148148

149149
public static final class KeepAliveProperties {
150150

151-
@NotNull
152-
private Boolean enabled = true;
153-
private long tickPeriodSeconds = 20;
154-
private long ackTimeoutSeconds = 30;
155-
private int missedAcks = 3;
151+
@NotNull private Boolean enabled = true;
152+
private long tickPeriodSeconds = 20;
153+
private long ackTimeoutSeconds = 30;
154+
private int missedAcks = 3;
156155

157156
public long getAckTimeoutSeconds() {
158157
return ackTimeoutSeconds;

netifi-spring-boot-autoconfigure/src/test/java/com/netifi/spring/boot/test/BrokerClientSpringIntegrationTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,6 @@
4646

4747
@ExtendWith(SpringExtension.class)
4848
@SpringBootTest
49-
@DirtiesContext
50-
@ImportAutoConfiguration({
51-
BrokerClientAutoConfiguration.class,
52-
BrokerClientConfiguration.class,
53-
BrokerClientSpringIntegrationTest.TestConfiguration.class
54-
})
5549
public class BrokerClientSpringIntegrationTest {
5650

5751
@Autowired ConfigurableListableBeanFactory beanFactory;

netifi-spring-boot-autoconfigure/src/test/java/com/netifi/spring/boot/test/ClientConfigurationIntegrationTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,19 +34,19 @@
3434
import org.springframework.test.context.junit.jupiter.SpringExtension;
3535

3636
@ExtendWith(SpringExtension.class)
37-
@SpringBootTest(classes = {
38-
ClientConfigurationIntegrationTest.TestConfiguration.class,
39-
BrokerClientAutoConfiguration.class,
40-
BrokerClientConfiguration.class
41-
})
37+
@SpringBootTest
4238
public class ClientConfigurationIntegrationTest {
4339

4440
@Autowired
4541
@Qualifier("mock2")
4642
BrokerClientConfigurer configurer;
4743

44+
@Autowired
45+
BrokerClient brokerClient;
46+
4847
@Test
4948
public void testThatConfigurerWorks() {
49+
Assertions.assertNotNull(brokerClient);
5050
ArgumentCaptor<BrokerClient.CustomizableBuilder> captor =
5151
ArgumentCaptor.forClass(BrokerClient.CustomizableBuilder.class);
5252

@@ -56,7 +56,7 @@ public void testThatConfigurerWorks() {
5656
}
5757

5858
@org.springframework.boot.test.context.TestConfiguration
59-
@ComponentScan
59+
// @ComponentScan
6060
static class TestConfiguration {
6161

6262
@Bean
Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,31 @@
1+
/*
2+
* Copyright 2019 The Netifi Authors
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
116
package com.netifi.spring.boot.test;
217

3-
import reactor.core.publisher.Mono;
4-
5-
import org.springframework.core.io.buffer.DataBuffer;
618
import org.springframework.messaging.handler.annotation.MessageMapping;
719
import org.springframework.messaging.handler.annotation.Payload;
820
import org.springframework.stereotype.Controller;
21+
import reactor.core.publisher.Mono;
922

1023
@Controller
1124
@MessageMapping("test")
1225
public class MessageHandler {
1326

14-
@MessageMapping("process")
15-
public Mono<String> process(@Payload Mono<String> data) {
16-
return Mono.just("Echo: " + data);
17-
}
27+
@MessageMapping("process")
28+
public Mono<String> process(@Payload Mono<String> data) {
29+
return Mono.just("Echo: " + data);
30+
}
1831
}

netifi-spring-boot-autoconfigure/src/test/java/com/netifi/spring/boot/test/SpringMessagingIntegrationTest.java

Lines changed: 6 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -17,26 +17,15 @@
1717

1818
import com.netifi.spring.core.annotation.Group;
1919
import org.junit.Assert;
20-
import org.junit.Before;
21-
import org.junit.ClassRule;
22-
import org.junit.jupiter.api.AfterAll;
23-
import org.junit.jupiter.api.BeforeAll;
2420
import org.junit.jupiter.api.Test;
2521
import org.junit.jupiter.api.extension.ExtendWith;
26-
import org.testcontainers.containers.GenericContainer;
27-
import org.testcontainers.containers.wait.strategy.HostPortWaitStrategy;
28-
import org.testcontainers.containers.wait.strategy.Wait;
29-
import org.testcontainers.containers.wait.strategy.WaitStrategy;
30-
import org.testcontainers.containers.wait.strategy.WaitStrategyTarget;
31-
3222
import org.springframework.boot.test.context.SpringBootTest;
3323
import org.springframework.messaging.rsocket.RSocketRequester;
34-
import org.springframework.test.context.event.annotation.BeforeTestClass;
3524
import org.springframework.test.context.junit.jupiter.SpringExtension;
25+
import org.testcontainers.containers.GenericContainer;
3626

3727
@ExtendWith(SpringExtension.class)
3828
@SpringBootTest
39-
//@TestPropertySource(locations="classpath:application.properties")
4029
public class SpringMessagingIntegrationTest {
4130

4231
public static GenericContainer redis =
@@ -45,17 +34,14 @@ public class SpringMessagingIntegrationTest {
4534
.withEnv(
4635
"BROKER_SERVER_OPTS",
4736
"-Dnetifi.authentication.0.accessKey=9007199254740991 "
48-
+ "-Dnetifi.authentication.0.accessToken=kTBDVtfRBO4tHOnZzSyY5ym2kfY= "
49-
+ "-Dnetifi.broker.admin.accessKey=9007199254740991 "
50-
+ "-Dnetifi.broker.admin.accessToken=kTBDVtfRBO4tHOnZzSyY5ym2kfY="
51-
);
52-
37+
+ "-Dnetifi.authentication.0.accessToken=kTBDVtfRBO4tHOnZzSyY5ym2kfY= "
38+
+ "-Dnetifi.broker.admin.accessKey=9007199254740991 "
39+
+ "-Dnetifi.broker.admin.accessToken=kTBDVtfRBO4tHOnZzSyY5ym2kfY=");
5340

5441
static {
5542
redis.start();
5643
System.setProperty("netifi.client.broker.hostname", redis.getContainerIpAddress());
57-
System.setProperty("netifi.client.broker.port",
58-
String.valueOf(redis.getMappedPort(8001)));
44+
System.setProperty("netifi.client.broker.port", String.valueOf(redis.getMappedPort(8001)));
5945
}
6046

6147
@Group("com.netifi.client.demo.vowelcount")
@@ -65,10 +51,6 @@ public class SpringMessagingIntegrationTest {
6551
public void tests() {
6652
Assert.assertNotNull(requester.rsocket());
6753

68-
requester.route("test.process")
69-
.data("test")
70-
.retrieveMono(String.class)
71-
.log()
72-
.block();
54+
requester.route("test.process").data("test").retrieveMono(String.class).log().block();
7355
}
7456
}

netifi-spring-boot-autoconfigure/src/test/java/com/netifi/spring/boot/test/TestApplication.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,15 @@
1818
import com.netifi.spring.boot.BrokerClientAutoConfiguration;
1919
import com.netifi.spring.boot.BrokerClientMessagingAutoConfiguration;
2020
import com.netifi.spring.core.config.BrokerClientConfiguration;
21-
2221
import org.springframework.boot.SpringApplication;
2322
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
2423
import org.springframework.boot.autoconfigure.SpringBootApplication;
2524

2625
@SpringBootApplication
2726
@ImportAutoConfiguration({
28-
BrokerClientMessagingAutoConfiguration.class,
29-
BrokerClientAutoConfiguration.class,
30-
BrokerClientConfiguration.class,
27+
BrokerClientMessagingAutoConfiguration.class,
28+
BrokerClientAutoConfiguration.class,
29+
BrokerClientConfiguration.class,
3130
})
3231
public class TestApplication {
3332
public static void main(String[] args) {

netifi-spring-core/src/main/java/com/netifi/spring/core/annotation/BrokerClientBeanDefinitionRegistryPostProcessor.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@ public void postProcessBeanDefinitionRegistry(BeanDefinitionRegistry registry)
6767
@Override
6868
public Object getSuggestedValue(DependencyDescriptor descriptor) {
6969
List<BrokerClientFactorySupport> brokerClientFactories =
70-
new ArrayList<>(beanFactory.getBeansOfType(BrokerClientFactorySupport.class).values());
70+
new ArrayList<>(
71+
beanFactory.getBeansOfType(BrokerClientFactorySupport.class).values());
7172

7273
AnnotationAwareOrderComparator.sort(brokerClientFactories);
7374

@@ -80,8 +81,7 @@ public Object getSuggestedValue(DependencyDescriptor descriptor) {
8081

8182
if (annotation != null) {
8283
Class<?> descriptorDeclaredType = descriptor.getDeclaredType();
83-
String[] beanNamesForType =
84-
beanFactory.getBeanNamesForType(descriptorDeclaredType);
84+
String[] beanNamesForType = beanFactory.getBeanNamesForType(descriptorDeclaredType);
8585

8686
for (String beanName : beanNamesForType) {
8787
BeanDefinition beanDefinition = beanFactory.getMergedBeanDefinition(beanName);
@@ -119,9 +119,7 @@ public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory)
119119
throws BeansException {}
120120

121121
private static boolean isSuportedByFactories(
122-
Collection<BrokerClientFactorySupport> brokerClientFactories,
123-
Class<?> clazz
124-
) {
122+
Collection<BrokerClientFactorySupport> brokerClientFactories, Class<?> clazz) {
125123
for (BrokerClientFactorySupport factory : brokerClientFactories) {
126124
if (factory.support(clazz)) {
127125
return true;

netifi-spring-core/src/main/java/com/netifi/spring/core/config/BrokerClientConfiguration.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import com.netifi.broker.info.BrokerInfoService;
2323
import com.netifi.broker.info.BrokerInfoServiceClient;
2424
import com.netifi.broker.info.BrokerInfoServiceServer;
25-
import com.netifi.common.tags.Tags;
2625
import com.netifi.spring.core.BrokerClientApplicationEventListener;
2726
import com.netifi.spring.core.annotation.BrokerClientBeanDefinitionRegistryPostProcessor;
2827
import com.netifi.spring.core.annotation.RpcBrokerClientFactorySupport;
@@ -42,8 +41,6 @@
4241
import org.springframework.context.annotation.AnnotatedBeanDefinitionReader;
4342
import org.springframework.context.annotation.Bean;
4443
import org.springframework.context.annotation.Configuration;
45-
import org.springframework.core.annotation.Order;
46-
4744
import reactor.core.scheduler.Scheduler;
4845

4946
@Configuration

0 commit comments

Comments
 (0)