Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clean up project setup #51

Merged
merged 12 commits into from
Oct 11, 2024
Merged

refactor: clean up project setup #51

merged 12 commits into from
Oct 11, 2024

Conversation

ndhoule
Copy link
Contributor

@ndhoule ndhoule commented Oct 11, 2024 •
edited
Loading

This changeset:

  • Updates SDK dependencies
  • Sets up ESLint
  • Fixes lint errors
  • Simplifies the TypeScript config, fixes it so several import * as {...} from "node:{...}" imports are no longer necessary, and sets it up to check all files (some were missing)
  • Fixes new type errors
  • Adds a few helper scripts to package.json#scripts
  • Adds some TODO/FIXME notes for various potential issues and cleanups I noticed along the way
  • Sets up CI

@netlify Netlify
Copy link

netlify bot commented Oct 11, 2024 •
edited
Loading

✅ Deploy Preview for csp-integration ready!

Name Link
🔨 Latest commit 1551654
🔍 Latest deploy log https://app.netlify.com/sites/csp-integration/deploys/670977d388e01f00080f1d87
😎 Deploy Preview https://deploy-preview-51--csp-integration.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

YujohnNattrass
YujohnNattrass approved these changes Oct 11, 2024
View reviewed changes
Copy link

@YujohnNattrass YujohnNattrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 👍

@ndhoule ndhoule merged commit 34d03a2 into main Oct 11, 2024
5 checks passed
@ndhoule ndhoule deleted the fix/csp-broken-make-work-good-refactors branch October 11, 2024 19:21
ndhoule added a commit that referenced this pull request Oct 21, 2024
@ndhoule
Revert "refactor: clean up project setup (#51)"
5036285 
This reverts commit 34d03a2.
ndhoule added a commit that referenced this pull request Oct 24, 2024
@ndhoule
revert: revert migration to CSP v2 (#55)
b74d771 
* Revert "fix: revert guard removal made in 9cb2744 (#54)"

This reverts commit a6a4c08.

* Revert "refactor: clean up project setup (#51)"

This reverts commit 34d03a2.

* Revert "feat: migration to SDK v2 (#40)"

This reverts commit 9cb2744.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YujohnNattrass YujohnNattrass YujohnNattrass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndhoule @YujohnNattrass