merging eigenstrapping with neuromaps #158
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am the lead author on the
eigenstrapping
preprint: https://www.biorxiv.org/content/10.1101/2024.02.07.579070v1I'd like to request its addition to the
neuromaps
package as a null method - you can findeigenstrapping
here. I've made my best attempt to integrate it with the existingneuromaps.nulls
functionalities, though there are some idiosyncrasies with the dependencies (particularly withnetneurotools
, the update to thescipy
libraries. more testing fully needed. Maybe this could be part of a development branch ofneuromaps
until the kinks can be ironed out.Thanks.