Presenter::$layout can be either string or null #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
force-pushed
the
master
branch
7 times, most recently
from
7e42997 to
f7df426
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
0e26720 to
e65cf05
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
7fe78c1 to
8f1bb54
Compare
dg
force-pushed
the
master
branch
13 times, most recently
from
c8eff84 to
447af2d
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
e3d05b3 to
929a242
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
426e735 to
c19ebdc
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
2b9da37 to
30d90f4
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
bf86204 to
c91f90a
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
57bd587 to
e908315
Compare
dg
force-pushed
the
master
branch
8 times, most recently
from
c5ecbda to
ecb200c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not really
string|boolbutstring|false|null, which kinda surprised me when I was implementing own layout finderThis variant is the only one I found which simplifies problem and does not break default implementation. Not sure about custom ones.
Alternative variant is change of annotation to
string|false|null, but it's ugly.