Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG Fix joblib dependency in sklearn #5

Closed
PSSF23 opened this issue Mar 2, 2023 · 4 comments · Fixed by #6
Closed

BUG Fix joblib dependency in sklearn #5

PSSF23 opened this issue Mar 2, 2023 · 4 comments · Fixed by #6
Assignees
@PSSF23
Labels
bug Something isn't working

Comments

@PSSF23
Copy link
Member

PSSF23 commented Mar 2, 2023

@sampan501 Can you share the commented-out lines here?
@PSSF23 PSSF23 added the bug Something isn't working label Mar 2, 2023
@rflperry
Copy link
Member

rflperry commented Mar 2, 2023 •
edited
Loading

The open pull request #4 has a fix, it was just missing an update to the requirements.txt file I believe.

@PSSF23
Copy link
Member Author

PSSF23 commented Mar 2, 2023

@rflperry I don't think the author of #4 is still contributing. Should we separate the fix into another PR?

@rflperry
Copy link
Member

rflperry commented Mar 2, 2023

@PSSF23 Yeah, something like that should be two PRs anyways. I was just saying the needed code modifications/discussion (in theory) are in that PR.

@PSSF23
Copy link
Member Author

PSSF23 commented Mar 2, 2023

Surely, I will try to apply the fix then.

@PSSF23 PSSF23 self-assigned this Mar 2, 2023
@PSSF23 PSSF23 mentioned this issue Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PSSF23 PSSF23

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@rflperry @PSSF23