-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with building developer changes in wp-module-ecommerce module. #6
Comments
Ah yes, I believe that the plugin's javascript package is not using the branch code, and is still pulling from the published github package. I'll look into how to do a local build of the js to include in the build instead. |
@sangeetha-nayak - I've verified that the According to the log it looks like the module js build step works, and then those are synced into the node_modules dir properly. Is that |
@circlecube Unfortunately it still does not seem to have dev changes. Here is the site where the plugin artifact is uploaded and changes from PRESS4-503 are non-verifiable here in this site |
I have tracked this down to the rsync command missing the trailing slash on the source directory. This PR should fix it: #8 |
#8 is now merged and I reran the tests on newfold-labs/wp-module-ecommerce#286 @sangeetha-nayak can you verify that you now see the changes in the build file? |
Summarize the issue (briefly)
The Build and Test Module Updates in Brand Plugin workflow does not seems to be building the plugin with right changes for wp-module-ecommerce. We have observed that the plugin artifact created after the workflow run is not having the dev changes from the branch where it is triggered. We had our own workflows written earlier to Build Brand Plugins for testing and run cypress tests against dev changes, but those were recently deleted via this PR #257 . Now we have to again go back to our trivial method of building brand plugins locally for each dev story which is time consuming. Please look into the issue and help us get the right artifacts.
Steps to reproduce
For instance refer dev story PRESS4-503 which is supposed to remove all react warnings mentioned in it. Also refer to the artifacts created with Brand Plugin test workflow.
Expected behavior

Here is the manually built plugin with dev changes which clearly shows that the react warnings that are reported in PRESS4-503 are fixed and no more errors on console.
Actual Behavior

Here is the plugin built from the workflow where all the react warnings reported in PRESS4-503 are still seen
Please take a look and ping PRESS4 for any further clarifications required or let us know if we are missing out on anything.
The text was updated successfully, but these errors were encountered: