Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tap cleanup #2799

Open
bizob2828 opened this issue Nov 25, 2024 · 1 comment · May be fixed by #2804
Open

Tap cleanup #2799

bizob2828 opened this issue Nov 25, 2024 · 1 comment · May be fixed by #2804
Assignees
@bizob2828
Labels
points: 3 A few days

Comments

@bizob2828
Copy link
Member

Description

Tap is no longer being used to write and run tests. We should clean the following:

  • Remove test/lib/custom-tap-assertions
  • Uninstall tap from dependency list
  • Remove custom tap assertions and its functions from test/lib/metrics_helper.js
  • Any other references to tap
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-343734

@newrelic-node-agent-team newrelic-node-agent-team moved this to Triage Needed: Unprioritized Features in Node.js Engineering Board Nov 25, 2024
@bizob2828 bizob2828 self-assigned this Nov 26, 2024
@bizob2828 bizob2828 added points: 3 A few days and removed needs-triage labels Nov 26, 2024
@bizob2828 bizob2828 moved this from Triage Needed: Unprioritized Features to In progress: Issues being worked on in Node.js Engineering Board Nov 26, 2024
@bizob2828 bizob2828 linked a pull request Nov 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bizob2828 bizob2828

Labels
points: 3 A few days
Projects
Node.js Engineering Board
Status: In progress: Issues being worked on
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Removed tap and cleaned up left over tap helpers bizob2828/node-newrelic
1 participant
@bizob2828