New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion: naming scheme #290

Open

thgoebel opened this issue Feb 20, 2024 · 1 comment

Contributor

thgoebel commented Feb 20, 2024

Some functions use color as the prefix verb, others use theme or tint.

What is the pattern here? When should I use which verb when adding functions?

tint: currently used only with drawables. To apply a tint to the drawable.
color: ?? (Used e.g. with MaterialButtons to apply tint to them.)
theme ??

The text was updated successfully, but these errors were encountered:

Member

AndyScherzinger commented Feb 20, 2024

Good question, currently as mentioned rather inconsistent in use.

So I would say

tint for actually tinting
Color for any kind of coloring
Theming for potentially multiple changes at once on an element and applying color tokens based on the Material 3 specification

thgoebel added a commit that referenced this issue


          Add theme utils from MoneyBuster

cb177b2

These were added by MoneyBuster here:
https://gitlab.com/eneiluj/moneybuster/-/merge_requests/43

Following the discussion in #290,
the naming scheme in this commit differs slightly from what was originally used
in MoneyBuster.

thgoebel mentioned this issue

Add theme utils from MoneyBuster #291

Merged

thgoebel added a commit that referenced this issue


          Add theme utils from MoneyBuster

9d5ec06

These were added by MoneyBuster here:
https://gitlab.com/eneiluj/moneybuster/-/merge_requests/43

Following the discussion in #290,
the naming scheme in this commit differs slightly from what was originally used
in MoneyBuster.

thgoebel added a commit that referenced this issue


          Add theme utils from MoneyBuster

2f72207

These were added by MoneyBuster here:
https://gitlab.com/eneiluj/moneybuster/-/merge_requests/43

Following the discussion in #290,
the naming scheme in this commit differs slightly from what was originally used
in MoneyBuster.

Signed-off-by: Thore Goebel <[email protected]>

thgoebel added a commit that referenced this issue


          Add theme utils from MoneyBuster

c10522b

These were added by MoneyBuster here:
https://gitlab.com/eneiluj/moneybuster/-/merge_requests/43

Following the discussion in #290,
the naming scheme in this commit differs slightly from what was originally used
in MoneyBuster.

Signed-off-by: Thore Goebel <[email protected]>

thgoebel added a commit that referenced this issue


          Add theme utils from MoneyBuster

e520394

These were added by MoneyBuster here:
https://gitlab.com/eneiluj/moneybuster/-/merge_requests/43

Following the discussion in #290,
the naming scheme in this commit differs slightly from what was originally used
in MoneyBuster.

Signed-off-by: Thore Goebel <[email protected]>

thgoebel added a commit that referenced this issue


          Add theme utils from MoneyBuster

791a593

These were added by MoneyBuster here:
https://gitlab.com/eneiluj/moneybuster/-/merge_requests/43

Following the discussion in #290,
the naming scheme in this commit differs slightly from what was originally used
in MoneyBuster.

Signed-off-by: Thore Goebel <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment