Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-line reply functionality to notifications from Nextcloud Talk #2908

Closed
HammyHavoc opened this issue Feb 7, 2021 · 7 comments · Fixed by #4200
Closed

Add in-line reply functionality to notifications from Nextcloud Talk #2908

HammyHavoc opened this issue Feb 7, 2021 · 7 comments · Fixed by #4200
Assignees
Labels
confirmed bug approved by the team

Comments

@HammyHavoc
Copy link

Other communication apps support this, and it's amazingly useful because it saves you from having to open Talk in a browser tab from the notification. Might only save a few seconds, but it makes all the difference.

@HammyHavoc HammyHavoc changed the title Add in-line reply functionality to notifications on Windows 10 Add in-line reply functionality to notifications from Nextcloud Talk on Windows 10 Feb 7, 2021
@camilasan camilasan self-assigned this Feb 8, 2021
@jancborchardt
Copy link
Member

@HammyHavoc yes, great point! :) Do you have some screenshots on how this looks like for other apps on Windows in your case (and maybe also macOS if this exists)? Thanks!

@HammyHavoc
Copy link
Author

@camilasan
Copy link
Member

What I actually have in mind is much more simple, it is without integration with the OS - that makes it much more complex to maintain it for the 3 platforms. I would do a widget for the reply. What do you think @jancborchardt @tobiasKaminsky?

@jancborchardt
Copy link
Member

@camilasan by widget you mean that it could show directly in the tray modal? Maybe sort of like this mockup: nextcloud/notifications#637 – that would definitely be nice. :)

@camilasan
Copy link
Member

by widget you mean that it could show directly in the tray modal?

yes, in head that is how it would work :) I need to check if I can do exactly like it.

@HammyHavoc
Copy link
Author

What I actually have in mind is much more simple, it is without integration with the OS - that makes it much more complex to maintain it for the 3 platforms. I would do a widget for the reply. What do you think @jancborchardt @tobiasKaminsky?

Native integration is obviously preferred; having notifications appear on an OS where notifications are expected to appear makes more sense than hiding them in a tray icon where users aren't likely to look if they're not expecting to find them there.

@mgallien mgallien added the confirmed bug approved by the team label Aug 25, 2021
@tobiasKaminsky tobiasKaminsky changed the title Add in-line reply functionality to notifications from Nextcloud Talk on Windows 10 Add in-line reply functionality to notifications from Nextcloud Talk Sep 30, 2021
@nickvergessen
Copy link
Member

As discussed the missing message id will be added to the objectId field of the notification.
Currently it is conversationToken and in the future it will be conversationToken/messageId with messageId being a bigint and conversationToken being a string like before.

@camilasan camilasan mentioned this issue Feb 1, 2022
9 tasks
@tobiasKaminsky tobiasKaminsky linked a pull request Feb 7, 2022 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug approved by the team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants