Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Limit SetupCheck computing time to 5 seconds #1178

Merged
merged 2 commits into from
Mar 12, 2024
Merged

feat: Limit SetupCheck computing time to 5 seconds #1178

merged 2 commits into from
Mar 12, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Mar 11, 2024

See #1170

In case of early stop, it will show in the output since when was the number of errors or warnings counted.

Also added time to the output in case the date is today.

@come-nc
feat: Limit SetupCheck computing time to 5 seconds
7af84d9 
In case of early stop, it will show in the output since when was the
number of errors or warnings counted.

Also added time to the output in case the date is today.

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc added this to the Nextcloud 29 milestone Mar 11, 2024
@come-nc come-nc requested a review from nickvergessen March 11, 2024 10:22
@come-nc come-nc self-assigned this Mar 11, 2024
@come-nc
Copy link
Contributor Author

come-nc commented Mar 11, 2024 •
edited
Loading

Planned follow-ups:

  • Catch exceptions from logfactory
  • request $this->config->getSystemValue('log_type', 'file') instead of 'file'
  • [server] Catch throwables from setupchecks and show a generic error
  • [server] Time setup checks and logs slow ones as info

@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Merged
@come-nc come-nc merged commit 43e6c1f into master Mar 12, 2024
25 checks passed
@come-nc come-nc deleted the feat/hardlimit-setupcheck-runtime branch March 12, 2024 10:39
@come-nc come-nc mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim

Assignees

@come-nc come-nc

Labels
3. to review
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
2 participants
@come-nc @nickvergessen