Skip to content

Date and Time representations are inconsistent, leading to ambiguity #4754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gdevenyi opened this issue Feb 16, 2024 · 8 comments
Open

Date and Time representations are inconsistent, leading to ambiguity #4754

gdevenyi opened this issue Feb 16, 2024 · 8 comments

Comments

@gdevenyi
Copy link

gdevenyi commented Feb 16, 2024

Bug report

The current implementations of human-readable dates and times are ambiguous in terms of their timezone, and in the case of durations, difficult to properly parse.

Expected behavior and actual behavior

Current dates are ambiguous of timezone:
2024-02-16 02:22:56.668

Should be
2024-02-16T02:22:56.668-05:00 (in my case Eastern)
or universal time
2024-02-16T07:22:56.668+00:00

https://en.wikipedia.org/wiki/ISO_8601

Similarly, durations, such as in the trace report:
5h 50m 9s

Should use the duration format of ISO
https://en.wikipedia.org/wiki/ISO_8601#Durations

PT5H50M9S

Or the alternative, perhaps more familiar
PT05:50:09

Steps to reproduce the problem

Observe existing date/time representations

N/A

Environment

  • Nextflow version: version 23.10.0 build 5891
  • Java version: OpenJDK 64-Bit Server VM Temurin-17.0.6+10 (build 17.0.6+10, mixed mode, sharing)
  • Operating system: Linux
  • Bash version: n 5.1.16(1)-release

Additional context

Implementation shouldn't be too hard as I think these are all human-readable outputs and not used internally, but existing libraries should have proper formatting options already available here.

@ashsgelb
Copy link

ashsgelb commented Apr 9, 2024

Hi, I would like to try and work on this task. Does this just consist of going through all of the files and finding anywhere where dates exist and changing them with a more clear format? And if so how would I know which files to look at specifically which do contain dates. I am sorry I am new and would like to contribute to this project. Thanks for the help!

Copy link

stale bot commented Apr 26, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@gdevenyi
Copy link
Author

Bug remains

@pditommaso
Copy link
Member

Can you provide more details where would you expect ISO date string ?

In the meanwhile i've crated this PR #6013

@gdevenyi
Copy link
Author

Can you provide more details where would you expect ISO date string ?

In report.html:

Image

Later on in the report table things are OK, this issue is so old I don't know if this was different beofre:

Image

In timeline.html:

Image

@gdevenyi
Copy link
Author

gdevenyi commented Apr 28, 2025

The execution log is not in ISO format
https://www.nextflow.io/docs/latest/reports.html#execution-log

@gdevenyi
Copy link
Author

The submit in the trace log is not in ISO format
https://www.nextflow.io/docs/latest/reports.html#trace-file

@gdevenyi
Copy link
Author

The duration is not in ISO format:
https://en.wikipedia.org/wiki/ISO_8601#Durations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants