Detector channels #1252
Merged
Detector channels #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which slice of data to show in a plot by default. This is useful especially for datasets with more than 2 dimensions.
|
Thank you for the PR Aaron! First glance is looking good, I will review everything in detail next week. |
soph-dec
reviewed
Apr 11, 2023
There was a problem hiding this comment.
I think we should mention NXdetector_channel in NXdetector as well. I guess something like this might do?
<group name="CHANNELNAME_channel" type="NXdetector_channel">
<doc>
Group containing the description and metadata for a single channel from a multi-channel
detector.
Given an :ref:`NXdata` group linked as part of an NXdetector group that has an axis with
named channels (see the example in :ref:`NXdata </NXdata@default_slice-attribute>`),
the NXdetector will have a series of NXdetector_channel groups, one for each channel,
named CHANNELNAME_channel.
</doc>
</group>
Co-authored-by: Sophie Hotz [email protected]
Co-authored-by: soph-dec <[email protected]>
phyy-nx
force-pushed
the
detector_channel
branch
from
bc9ca80
to
ddfba34
Compare
Also add it as optional for NXmx See original Dectris proposal: https://github.com/dectris/documentation/tree/main/filewriter_v2#user-content-multi-channel-data Closes #940 Co-authored-by: Sophie Hotz <[email protected]>
phyy-nx
force-pushed
the
detector_channel
branch
from
ddfba34
to
81388d1
Compare
Co-authored-by: soph-dec <[email protected]>
Co-authored-by: Sophie Hotz <[email protected]>
Done! Also added to NXmx |
soph-dec
reviewed
Jun 20, 2023
soph-dec
reviewed
Jun 20, 2023
Co-authored-by: soph-dec <[email protected]>
Co-authored-by: Sophie Hotz <[email protected]> Co-authored-by: soph-dec <[email protected]>
Fix conflicts, adjusting phrase "Most dimensions scales will be sequences of numbers" to "Most AXISNAME fields will be sequences of numbers"
|
Conflicts fixed, no changes to this branch. Reviewers might find it easier to use this link to compare the |
soph-dec
added a commit
to soph-dec/documentation
that referenced
this pull request
Dec 1, 2023
For details see the open PR on github: nexusformat/definitions#1252
|
This PR is ready for a NIAC vote. Please vote with an emoji on this comment. Options include thumbs up for yes, thumbs down for no, and anything else to abstain. Thank you. Voting will close in two weeks. |
|
Vote has passed. Thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds NXdetector_channel as a base class and adds it as optional for NXmx. @soph-dec and @kalcutter I put in placeholder documentation. Can you review and comment?
See original Dectris proposal:
https://github.com/dectris/documentation/tree/main/filewriter_v2#user-content-multi-channel-data
Closes #940
Requires #1246 to be merged first
Co-authored-by: Sophie Hotz [email protected]