Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XDS: clarify the definition of the optional attribute in relation to minOccurs for fields and groups #1514

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

XDS: clarify the definition of the optional attribute in relation to minOccurs for fields and groups #1514

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80b508f
XDS: clarify the definition of the optional attribute in relation to …
woutdenolf Nov 23, 2024
d6d20f8
review
woutdenolf Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions nxdl.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,8 @@ https://stackoverflow.com/a/48980995/1046449 -->
<xs:attribute name="optional" use="optional" type="nx:NX_BOOLEAN" default="false" >
<xs:annotation>
<xs:documentation>
A synonym for minOccurs=0.
A value of "true" is equivalent to minOccurs=0 while a value of
"false" is equivalent to minOccurs>0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the choices as large as minOccurs>0? Or the only choice when false is minOccurs=1?

Copy link
Contributor Author

@woutdenolf woutdenolf Nov 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the choices as large as minOccurs>0?

Yes. Any nonNegativeUnbounded greater than zero. If it is supposed to be minOccurs=1 when optional=false then I can change that of course.

</xs:documentation>
</xs:annotation>
</xs:attribute>
Expand Down Expand Up @@ -837,7 +838,8 @@ https://stackoverflow.com/a/48980995/1046449 -->
<xs:attribute name="optional" use="optional" type="nx:NX_BOOLEAN" default="false" >
<xs:annotation>
<xs:documentation>
A synonym for minOccurs=0.
A value of "true" is equivalent to minOccurs=0 while a value of
"false" is equivalent to minOccurs>0.
</xs:documentation>
</xs:annotation>
</xs:attribute>
Expand Down
Loading