Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry recipe improvements #35

Open
zjttoefs opened this issue Jul 17, 2019 · 0 comments
Open

Geometry recipe improvements #35

zjttoefs opened this issue Jul 17, 2019 · 0 comments

Comments

@zjttoefs
Copy link
Contributor

8CB1EBAE3B2DA51D has lazy validation. In process() it only checks that geometry groups exist and that they are valid. No checks are done if the depends_on chain is there and checks out. There is some duplication between the simple verification code and the one that runs when running the full OFF building (hdf visitor).

Also: The title is too long and the NeXusOFF as no meaningful repr or str method. So the output from the processing of the recipe is not helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant