-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the meta.yml of subworkflows #7072
base: master
Are you sure you want to change the base?
Conversation
- versions: | ||
type: file | ||
description: File containing software versions | ||
pattern: "versions.yml" | ||
- bins: | ||
description: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand this change, why has it deleted the old description and just moved it down?
And why is it removing meta, (which should be in all output channels except versions in this case)
@mirpedrol can you provide more context what tools is trying to do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lint command with --fix
is fixing the structure of the meta, adding all input and output channels, for example in this case bin
is not a channel, because it's called bins
. But the description or structure can't be automatized, this must be fixed manually by copying the old descirption and/or checking the main.nf
of the subworkflow and meta.yml
of the included modules to know the proper content of the channels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, completely missed that typo, my bad!
OK thank you :)
@@ -46,6 +47,10 @@ output: | |||
description: | | |||
Files containing software versions | |||
Structure: [ path(versions.yml) ] | |||
- //: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also seems broken... @mirpedrol ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is but in tools, probably because of a multiline comment, thanks for pointing this out!
PR checklist
Closes #6737
nf-core lint --fix
for each subworkflow in the repo.meta.yml
files.versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda