Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Mergable Ingreseses - Minion Ingress shows incorrect port. #6754

Open
jo-carter opened this issue Nov 5, 2024 · 5 comments
Open

[Bug]: Mergable Ingreseses - Minion Ingress shows incorrect port. #6754

jo-carter opened this issue Nov 5, 2024 · 5 comments
Labels
bug An issue reporting a potential bug ready for refinement An issue that was triaged and it is ready to be refined

Comments

@jo-carter
Copy link
Contributor

jo-carter commented Nov 5, 2024

Version

3.5.2

What Kubernetes platforms are you running on?

Other

Steps to reproduce

Kubectl get ingress <ingress> output for Minion Ingresses shows an incorrect port value (80 only), when TLS enabled in the Master. The Master ingress shows the correct ports value 80, 443.

This can be reproduced using the Mergeable Ingresses example.

@jo-carter jo-carter added bug An issue reporting a potential bug needs triage An issue that needs to be triaged labels Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

Hi @jo-carter thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@j1m-ryan
Copy link
Contributor

Hi @jo-carter, thanks for reporting. We've replicated this and will look into to it further.
With the mergeable ingress example we get this currently

NAME                         CLASS   HOSTS              ADDRESS   PORTS     AGE
cafe-ingress-coffee-minion   nginx   cafe.example.com             80        32s
cafe-ingress-master          nginx   cafe.example.com             80, 443   32s
cafe-ingress-tea-minion      nginx   cafe.example.com             80        32

@j1m-ryan
Copy link
Contributor

It's not ideal but I don't think we can affect this programmatically. For printing ingresses, Kubernetes looks at the ingress spec.
If you add a TLS section to a minion, it will show up here, but will not make any difference in NIC.

@jo-carter
Copy link
Contributor Author

@j1m-ryan

It's not ideal but I don't think we can affect this programmatically. For printing ingresses, Kubernetes looks at the ingress spec.

I see. Maybe instead this should just be noted it in NIC documentation as expected behavior / as a quirk of mergeable ingresses in that case (?).

If you add a TLS section to a minion, it will show up here, but will not make any difference in NIC.

Thanks for sharing - this is a good workaround for cases where the user must have accurate port values with mergeable ingress, perhaps for some sort of external tooling that uses these port values - maybe it should also be noted in documentation (?).

@jo-carter
Copy link
Contributor Author

If you add a TLS section to a minion, it will show up here, but will not make any difference in NIC.

@j1m-ryan Actually on further inspection the minion is rejected if you attempt to add an entry to spec.tls.hosts, so this workaround cannot be used.

Warning Rejected 34s (x2 over 34s) nginx-ingress-controller spec.tls: Too many: 1: must have at most 0 items

@shaun-nx shaun-nx added ready for refinement An issue that was triaged and it is ready to be refined and removed needs triage An issue that needs to be triaged labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug ready for refinement An issue that was triaged and it is ready to be refined
Projects
Status: Todo ☑
Development

No branches or pull requests

3 participants