Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not copying some required header files #1

Open
nicole-mcg opened this issue Nov 20, 2018 · 5 comments
Open

Not copying some required header files #1

nicole-mcg opened this issue Nov 20, 2018 · 5 comments

Comments

@nicole-mcg
Copy link

I'm getting this error when running ./build.sh

file included from /Users/connor/code/libv8/v8/src/zone/accounting-allocator.h:17:
/Users/connor/code/libv8/v8/testing/gtest/include/gtest/gtest_prod.h:10:10: fatal error:
      'third_party/googletest/src/googletest/include/gtest/gtest_prod.h' file
      not found
#include "third_party/googletest/src/googletest/include/gtest/gtest_prod.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /Users/connor/code/libv8/v8/src/address-map.cc:6:
In file included from /Users/connor/code/libv8/v8/src/heap/heap.h:25:
In file included from /Users/connor/code/libv8/v8/src/objects/fixed-array.h:8:
In file included from /Users/connor/code/libv8/v8/src/maybe-handles.h:10:
In file included from /Users/connor/code/libv8/v8/src/handles.h:21:
In file included from /Users/connor/code/libv8/v8/src/zone/zone.h:16:
In file included from /Users/connor/code/libv8/v8/src/zone/accounting-allocator.h:17:
/Users/connor/code/libv8/v8/testing/gtest/include/gtest/gtest_prod.h:10:10: fatal error:
      'third_party/googletest/src/googletest/include/gtest/gtest_prod.h' file
      not found
#include "third_party/googletest/src/googletest/include/gtest/gtest_prod.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

I am looking into how to fix this, I'm not sure what the cause of this problem is

@nicole-mcg nicole-mcg changed the title Not copying some required includes Not copying some required header files Nov 21, 2018
@ngot
Copy link
Owner

ngot commented Nov 24, 2018

Thanks for your notice of my project. I did not pay too much attention to the v8 project recently. It might be some change in v8 that I have not covered. I will investigate it.

@nicole-mcg
Copy link
Author

I got it building using CMake on osx here https://stackoverflow.com/questions/53379099/c-v8-embedding-project-structure

@ngot
Copy link
Owner

ngot commented Dec 1, 2018

@C-McG Could you provide me with the reproduce steps? I have tried but not error occurred.

@nicole-mcg
Copy link
Author

I was getting this error on a mac (Mojave) by cloning your repo and following the Readme instructions

@ngot
Copy link
Owner

ngot commented Mar 13, 2019

v8 has changed a lot since then. The code inside repo is still compiling, but an upgrade is hard. I don't have enough time to do the upgrade now. If anyone could help me doing this, that will be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants