complete RTCP

yngrtc · yngrtc · commit 3b24972de6d5 · 2024-06-16T23:19:24.000-07:00
diff --git a/README.md b/README.md
@@ -36,7 +36,7 @@
     <img src="https://raw.githubusercontent.com/webrtc-rs/webrtc/master/doc/uncheck.png">DataChannel
     <br>
     <img src="https://raw.githubusercontent.com/webrtc-rs/webrtc/master/doc/check.png">RTP
-    <img src="https://raw.githubusercontent.com/webrtc-rs/webrtc/master/doc/uncheck.png">RTCP
+    <img src="https://raw.githubusercontent.com/webrtc-rs/webrtc/master/doc/check.png">RTCP
     <img src="https://raw.githubusercontent.com/webrtc-rs/webrtc/master/doc/uncheck.png">SRTP
     <img src="https://raw.githubusercontent.com/webrtc-rs/webrtc/master/doc/uncheck.png">SCTP
     <br>
diff --git a/Sources/RTCP/Packet.swift b/Sources/RTCP/Packet.swift
@@ -101,8 +101,8 @@ func unmarshaller(_ buf: ByteBuffer) throws -> (Packet, Int) {
         default:
             (packet, _) = try RawPacket.unmarshal(inPacket)
         }
-    /*TODO:case PacketType.extendedReport:
-        (packet, _) = try ExtendedReport.unmarshal(inPacket),*/
+    case PacketType.extendedReport:
+        (packet, _) = try ExtendedReport.unmarshal(inPacket)
     default:
         (packet, _) = try RawPacket.unmarshal(inPacket)
     }
diff --git a/Sources/RTCP/ReceptionReport.swift b/Sources/RTCP/ReceptionReport.swift
@@ -146,7 +146,7 @@ extension ReceptionReport: Unmarshal {
         guard let t2: UInt8 = reader.readInteger() else {
             throw RtcpError.errPacketTooShort
         }
-        // TODO: The type of `total_lost` should be `i32`, per the RFC:
+        // The type of `total_lost` should be `i32`, per the RFC:
         // The total number of RTP data packets from source SSRC_n that have
         // been lost since the beginning of reception.  This number is
         // defined to be the number of packets expected less the number of

Original file line number	Diff line number	Diff line change
`@@ -101,8 +101,8 @@ func unmarshaller(_ buf: ByteBuffer) throws -> (Packet, Int) {`
`101`	`101`	`default:`
`102`	`102`	`(packet, _) = try RawPacket.unmarshal(inPacket)`
`103`	`103`	`}`
`104`		`- /*TODO:case PacketType.extendedReport:`
`105`		`- (packet, _) = try ExtendedReport.unmarshal(inPacket),*/`
	`104`	`+ case PacketType.extendedReport:`
	`105`	`+ (packet, _) = try ExtendedReport.unmarshal(inPacket)`
`106`	`106`	`default:`
`107`	`107`	`(packet, _) = try RawPacket.unmarshal(inPacket)`
`108`	`108`	`}`
Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ extension ReceptionReport: Unmarshal {`
`146`	`146`	`guard let t2: UInt8 = reader.readInteger() else {`
`147`	`147`	`throw RtcpError.errPacketTooShort`
`148`	`148`	`}`
`149`		- // TODO: The type of `total_lost` should be `i32`, per the RFC:
	`149`	+ // The type of `total_lost` should be `i32`, per the RFC:
`150`	`150`	`// The total number of RTP data packets from source SSRC_n that have`
`151`	`151`	`// been lost since the beginning of reception. This number is`
`152`	`152`	`// defined to be the number of packets expected less the number of`