Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new templates rather than updating existing ones #133

Open
github-actions bot opened this issue Jun 4, 2022 · 0 comments
Open

Create new templates rather than updating existing ones #133

github-actions bot opened this issue Jun 4, 2022 · 0 comments
Labels

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2022

Create new templates rather than updating existing ones

This would eliminate issues from partial updates of templates as new attributes are added.

I think the logic is set up this way because order of the templates matters.

As finder already updates the local files, just update the template object

# TODO: Create new templates rather than updating existing ones

                kwargs.update(version=source.target_version)
            for template in source_with_templates.templates:
                new_template = finder.find(str(source.update_location), **kwargs)
                # TODO: Create new templates rather than updating existing ones
                #  This would eliminate issues from partial updates of templates as new attributes are added.
                #  I think the logic is set up this way because order of the templates matters.
                if template.version != new_template.version:
                    # Template needs to be upgraded
                    # As finder already updates the local files, just update the template object
                    template.update_from_template(new_template)


def _commit_message(renderables: Sequence[Renderable]) -> str:

6505e6c71412bf9ae45eb60150ffa0de9f634c13

@github-actions github-actions bot added the todo label Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

0 participants