Move --ieee-warnings to global options. Issue #1151

Author: nickg

NEWS.md

@@ -29,6 +29,9 @@
   original spelling of VHDL identifiers (#723).
 - Fixed wrong result of VHDL-2019 `std.env.file_path` when the source
   file was analysed using a relative path (#1162).
+- `--ieee-warnings` is now a global option and should be placed before
+  the `-r` command.  Passing it to the `-r` command is still supported
+  but deprecated and may not take effect in some situations (#1151).
 
 ## Version 1.15.1 - 2025-01-22
 - Fixed a crash when a subprogram is called with too many named arguments

contrib/nvc.bash

@@ -42,12 +42,13 @@ _nvc () {
 
   local global_opts='-L -h --help --messages= --std= -v --version --init --list
                      --install --work= -a -e -r -i --dump --print-deps --load=
-                     --map= --do --cover-report --cover-export --cover-merge'
+                     --map= --do --cover-report --cover-export --cover-merge
+                     --ieee-warnings='
   local analyse_opts='-D --define= --error-limit= --relaxed --psl --error-limit=
-                      -f --files --no-save'
+                      -f --files --no-save --preserve-case'
   local elab_opts='--cover --disable-opt --dump-llvm --dump-vcode --jit --no-save
                    --native -V --verbose'
-  local run_opts='--trace --stop-time= --ieee-warnings= --stats= --stop-delta=
+  local run_opts='--trace --stop-time= --stats= --stop-delta=
                   -w --wave --format='
   local export_opts='--format= -o --output='
   local merge_opts='-o --output='

nvc.1

@@ -113,6 +113,10 @@ operator.  The
 parameter takes an optional k, m, or g suffix to indicate kilobytes,
 megabytes, and gigabytes respectively.  The default size is 16
 megabytes.
+.\" --ieee-warnings
+.It Fl \-ieee-warnings= Ns Bo Cm on Ns | Ns Cm off Bc
+Enable or disable warning messages from the standard IEEE packages.  The
+default is warnings enabled.
 .\" --ignore-time
 .It Fl \-ignore-time
 Do not check the timestamps of source files when the corresponding
@@ -392,10 +396,6 @@ order with separators for each scope.
 This only makes sense in combination with the
 .Fl \-wave
 option.
-.\" --ieee-warnings
-.It Fl \-ieee-warnings= Ns Bo Cm on Ns | Ns Cm off Bc
-Enable or disable warning messages from the standard IEEE packages.  The
-default is warnings enabled.
 .\" --include, --exclude
 .It Fl \-include= Ns Ar glob , Fl \-exclude= Ns Ar glob
 Signals that match

src/nvc.c

@@ -755,7 +755,7 @@ static int run_cmd(int argc, char **argv, cmd_state_t *state)
       { "stop-delta",    required_argument, 0, 'd' },
       { "format",        required_argument, 0, 'f' },
       { "include",       required_argument, 0, 'i' },
-      { "ieee-warnings", required_argument, 0, 'I' },
+      { "ieee-warnings", required_argument, 0, 'I' },   // DEPRECATED 1.16
       { "exclude",       required_argument, 0, 'e' },
       { "exit-severity", required_argument, 0, 'x' },
       { "dump-arrays",   optional_argument, 0, 'a' },
@@ -847,7 +847,17 @@ static int run_cmd(int argc, char **argv, cmd_state_t *state)
          parse_exit_severity(optarg);
          break;
       case 'I':
-         opt_set_int(OPT_IEEE_WARNINGS, parse_on_off(optarg));
+         {
+            const bool on = parse_on_off(optarg);
+
+            // TODO: add an unconditional warning after 1.16
+            if (state->jit != NULL && opt_get_int(OPT_IEEE_WARNINGS) != on)
+               warnf("the $bold$--ieee-warnings$$ option may have no affect "
+                     "as the IEEE packages have already been initialised, pass "
+                     "$bold$--ieee-warnings$$ as a global option instead");
+
+            opt_set_int(OPT_IEEE_WARNINGS, on);
+         }
          break;
       case 'a':
          if (optarg == NULL)
@@ -862,7 +872,7 @@ static int run_cmd(int argc, char **argv, cmd_state_t *state)
          opt_set_int(OPT_SHUFFLE_PROCS, 1);
          break;
       default:
-         abort();
+         should_not_reach_here();
       }
    }
 
@@ -2069,6 +2079,8 @@ static void usage(void)
           "Global options may be placed before COMMAND:\n"
           " -h, --help\t\tDisplay this message and exit\n"
           " -H SIZE\t\tSet the maximum heap size to SIZE bytes\n"
+          "     --ieee-warnings=\tEnable ('on') or disable ('off') warnings\n"
+          "                     \tfrom IEEE packages\n"
           "     --ignore-time\tSkip source file timestamp check\n"
           "     --load=PLUGIN\tLoad VHPI plugin at startup\n"
           " -L PATH\t\tAdd PATH to library search paths\n"
@@ -2116,8 +2128,6 @@ static void usage(void)
           "     --exit-severity=\tExit after assertion failure of "
           "this severity\n"
           "     --format=FMT\tWaveform format is either fst or vcd\n"
-          "     --ieee-warnings=\tEnable ('on') or disable ('off') warnings\n"
-          "                     \tfrom IEEE packages\n"
           "     --include=GLOB\tInclude signals matching GLOB in wave dump\n"
           "     --shuffle\t\tRun processes in random order\n"
           "     --stats\t\tPrint time and memory usage at end of run\n"
@@ -2331,19 +2341,20 @@ int main(int argc, char **argv)
    atexit(fbuf_cleanup);
 
    static struct option long_options[] = {
-      { "help",        no_argument,       0, 'h' },
-      { "version",     no_argument,       0, 'v' },
-      { "work",        required_argument, 0, 'w' },
-      { "std",         required_argument, 0, 's' },
-      { "messages",    required_argument, 0, 'I' },
-      { "native",      no_argument,       0, 'n' },   // DEPRECATED 1.4
-      { "map",         required_argument, 0, 'p' },
-      { "ignore-time", no_argument,       0, 'i' },
-      { "force-init",  no_argument,       0, 'f' },   // DEPRECATED 1.7
-      { "stderr",      required_argument, 0, 'E' },
-      { "load",        required_argument, 0, 'l' },
-      { "vhpi-debug",  no_argument,       0, 'D' },
-      { "vhpi-trace",  no_argument,       0, 'T' },
+      { "help",          no_argument,       0, 'h' },
+      { "version",       no_argument,       0, 'v' },
+      { "work",          required_argument, 0, 'w' },
+      { "std",           required_argument, 0, 's' },
+      { "messages",      required_argument, 0, 'I' },
+      { "native",        no_argument,       0, 'n' }, // DEPRECATED 1.4
+      { "map",           required_argument, 0, 'p' },
+      { "ieee-warnings", required_argument, 0, 'W' },
+      { "ignore-time",   no_argument,       0, 'i' },
+      { "force-init",    no_argument,       0, 'f' }, // DEPRECATED 1.7
+      { "stderr",        required_argument, 0, 'E' },
+      { "load",          required_argument, 0, 'l' },
+      { "vhpi-debug",    no_argument,       0, 'D' },
+      { "vhpi-trace",    no_argument,       0, 'T' },
       { 0, 0, 0, 0 }
    };
 
@@ -2415,12 +2426,15 @@ int main(int argc, char **argv)
       case 'D':
          opt_set_int(OPT_PLI_DEBUG, 1);
          break;
+      case 'W':
+         opt_set_int(OPT_IEEE_WARNINGS, parse_on_off(optarg));
+         break;
       case '?':
          bad_option("global", argv);
       case ':':
          missing_argument("global", argv);
       default:
-         abort();
+         should_not_reach_here();
       }
    }
 

test/regress/cmdline14.sh

@@ -0,0 +1,22 @@
+set -xe
+
+nvc -a - <<-EOF
+library ieee;
+use ieee.std_logic_1164.all;
+use ieee.numeric_std.all;
+entity cmdline14 is
+end entity;
+architecture test of cmdline14 is
+  signal x : integer;
+  signal y : unsigned(7 downto 0) := to_unsigned(42, 8);
+begin
+  y <= (others => 'X');
+  x <= to_integer(y);
+end architecture;
+EOF
+
+nvc --ieee-warnings=on -e cmdline14 --jit --no-save -r cmdline14 2>err
+grep "NUMERIC_STD.TO_INTEGER: metavalue detected, returning 0" err
+
+nvc --ieee-warnings=off -e cmdline14 --jit --no-save -r cmdline14 2>err
+! grep "NUMERIC_STD.TO_INTEGER: metavalue detected, returning 0" err

test/regress/testlist.txt

@@ -1101,3 +1101,4 @@ debug4          normal,gold
 issue1150       normal,psl
 order4          shell
 issue1161       normal,vhpi,2008
+cmdline14       shell